Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move bundle asset tagging later #546

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
2 participants
@tivac
Copy link
Owner

commented Jan 21, 2019

Description

Allows for all filenames to be fully-resolved first, otherwise things get hairy. Also making sure that bundles are tagged even if they don't have any dependencies beyond their own CSS chunk

Motivation and Context

On a bigger project I was seeing some assets arrays have undefined values due to a bug. This is a bit of a brute-force fix, but it does work.

How Has This Been Tested?

Tested against a big project w/o errors. It makes the plugin ever so slightly slower but I doubt it matters much. I wasn't able to create a simple test to reproduce the error I was seeing unfortunately.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
fix: move bundle asset tagging later
Allows for all filenames to be fully-resolved first, otherwise things get hairy. Also making sure that bundles are tagged even if they don't have any dependencies beyond their own CSS chunk

@tivac tivac self-assigned this Jan 21, 2019

@TravisBuddy

This comment has been minimized.

Copy link

commented Jan 21, 2019

Hey @tivac,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b70db710-1dbb-11e9-b32e-4de5d53aa877
@TravisBuddy

This comment has been minimized.

Copy link

commented Jan 21, 2019

Hey @tivac,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a7d840f0-1dbe-11e9-b32e-4de5d53aa877
@codecov

This comment has been minimized.

Copy link

commented Jan 21, 2019

Codecov Report

Merging #546 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
+ Coverage   99.02%   99.02%   +<.01%     
==========================================
  Files          46       46              
  Lines        1027     1030       +3     
  Branches      157      157              
==========================================
+ Hits         1017     1020       +3     
  Misses         10       10
Impacted Files Coverage Δ
packages/rollup/rollup.js 100% <100%> (ø) ⬆️
packages/rollup-rewriter/rewriter.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5f77a...ea34038. Read the comment docs.

@tivac tivac merged commit 2fef785 into master Jan 21, 2019

4 checks passed

codecov/patch 100% of diff hit (target 99.02%)
Details
codecov/project 99.02% (+<.01%) compared to 1b5f77a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the delay-assets-tagging branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.