Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore external modules #555

merged 6 commits into from Jan 27, 2019


None yet
1 participant
Copy link

commented Jan 27, 2019


Modules flagged using external were throwing a wobbily, so now we filter 'em out.

Motivation and Context

I've got a project that uses external and it was breaking.

How Has This Been Tested?

Added a test, also it doesn't break in my other project.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tivac added some commits Jan 25, 2019

chore: make processor graph easier to read
Specify a short value for nodeData otherwise dependency-graph uses the key and those are really big. Doesn't affect functionality at all.
perf: don't iterate all bundles
Only the ones we already tagged as having some sort of CSS output.
wip: rework to filter at the intake
Allows for removing later checks because we know it's all safe.

@tivac tivac self-assigned this Jan 27, 2019


This comment has been minimized.

Copy link

commented Jan 27, 2019

Codecov Report

Merging #555 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
+ Coverage   99.03%   99.03%   +<.01%     
  Files          46       46              
  Lines        1039     1040       +1     
  Branches      163      161       -2     
+ Hits         1029     1030       +1     
  Misses         10       10
Impacted Files Coverage Δ
packages/processor/processor.js 100% <100%> (ø) ⬆️
packages/rollup/rollup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd29d9...a40e2a8. Read the comment docs.

@tivac tivac merged commit 5a6fcd9 into master Jan 27, 2019

4 checks passed

codecov/patch 100% of diff hit (target 99.03%)
codecov/project 99.03% (+<.01%) compared to ffd29d9
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@tivac tivac deleted the ignore-externals branch Jan 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.