Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata output breaks when common.css is output #556

Merged
merged 2 commits into from Jan 28, 2019

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Jan 28, 2019

Description

Files that rollup hasn't actually processed but live within the processor instance are put into common.css. This file becomes part of the out set, but doesn't live within the bundle from rollup. If you don't validate that the file exists in the bundle before trying to do stuff with it things get real 馃敟 馃拃-y.

Motivation and Context

Fixes a bug I haven't reported yet.

How Has This Been Tested?

Tests, real world project that surfaced the issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tivac added some commits Jan 28, 2019

fix: bundle entries don't always exist
Specifically in the case where the plugin is outputting a "common.css" file that includes all the CSS that rollup itself didn't walk.

@tivac tivac self-assigned this Jan 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Jan 28, 2019

Codecov Report

Merging #556 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   99.03%   99.04%   +<.01%     
==========================================
  Files          46       46              
  Lines        1040     1042       +2     
  Branches      161      162       +1     
==========================================
+ Hits         1030     1032       +2     
  Misses         10       10
Impacted Files Coverage 螖
packages/rollup/rollup.js 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ef5cfaa...2db09e6. Read the comment docs.

@tivac tivac merged commit bf50079 into master Jan 28, 2019

4 checks passed

codecov/patch 100% of diff hit (target 99.03%)
Details
codecov/project 99.04% (+<.01%) compared to ef5cfaa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the metadata-common-explosion branch Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.