Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove newlines left over after deleting composes declarations #561

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Feb 5, 2019

Description

.foo {
-    
    color: fuschia;
}

Motivation and Context

I always hated that extra newline but never took the time to get rid of it.

How Has This Been Tested?

Updated a whoooooooole bunch of snapshots.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tivac tivac self-assigned this Feb 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 5, 2019

Codecov Report

Merging #561 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
+ Coverage   99.04%   99.04%   +<.01%     
==========================================
  Files          46       46              
  Lines        1045     1047       +2     
  Branches      163      163              
==========================================
+ Hits         1035     1037       +2     
  Misses         10       10
Impacted Files Coverage Δ
packages/processor/plugins/composition.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bede9a3...0f4d813. Read the comment docs.

@tivac tivac merged commit 23569dc into master Feb 5, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 99.04%)
Details
codecov/project 99.04% (+<.01%) compared to bede9a3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@tivac tivac deleted the newlines-nom-nom-nom branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.