Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netlify deploys #566

Merged
merged 3 commits into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@tivac
Copy link
Owner

commented Feb 9, 2019

Just me flopping around for a bit...

@tivac tivac self-assigned this Feb 9, 2019

@TravisBuddy

This comment has been minimized.

Copy link

commented Feb 9, 2019

Travis tests have failed

Hey @tivac,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

View build log

npm test -- --ci
> modular-css@0.0.0 pretest /home/travis/build/tivac/modular-css
> npm run parser


> modular-css@0.0.0 parser /home/travis/build/tivac/modular-css
> pegjs packages/processor/parsers/parser.pegjs


> modular-css@0.0.0 test /home/travis/build/tivac/modular-css
> jest "--ci"

PASS lint packages/rollup/test/rollup.test.js
  ● Console

    console.warn 
      
      /home/travis/build/tivac/modular-css/packages/rollup/test/rollup.test.js
        666:9  warning  Skipped test  jest/no-disabled-tests
      
      ✖ 1 problem (0 errors, 1 warning)
      

PASS lint packages/processor/test/options.test.js
PASS lint packages/processor/test/api.test.js
PASS lint packages/rollup/test/splitting.test.js
PASS lint packages/processor/processor.js
PASS lint packages/rollup/test/watch.test.js
  ● Console

    console.warn 
      
      /home/travis/build/tivac/modular-css/packages/rollup/test/watch.test.js
        7:7  warning  'read' is assigned a value but never used  no-unused-vars
      
      ✖ 1 problem (0 errors, 1 warning)
      

PASS lint packages/svelte/test/svelte.test.js
PASS lint packages/rollup/rollup.js
PASS lint packages/webpack/test/webpack.test.js
  ● Console

    console.warn 
      
      /home/travis/build/tivac/modular-css/packages/webpack/test/webpack.test.js
        126:5   warning  Skipped test                                    jest/no-disabled-tests
        130:13  warning  Unexpected console statement                    no-console
        130:25  warning  Use the rest parameters instead of 'arguments'  prefer-rest-params
      
      ✖ 3 problems (0 errors, 3 warnings)
      

PASS lint packages/browserify/browserify.js
PASS lint packages/browserify/test/factor-bundle.test.js
PASS lint packages/svelte/svelte.js
PASS lint packages/browserify/test/browserify.test.js
PASS lint packages/processor/test/composition.test.js
PASS lint packages/processor/test/values.test.js
PASS lint packages/rollup-rewriter/test/rewriter.test.js
PASS lint packages/www/rollup.config.js
PASS lint packages/www/src/repl/store.js
  ● Console

    console.warn 
      
      /home/travis/build/tivac/modular-css/packages/www/src/repl/store.js
         97:13  warning  Unexpected console statement  no-console
        117:13  warning  Unexpected console statement  no-console
      
      ✖ 2 problems (0 errors, 2 warnings)
      

PASS lint packages/postcss/test/postcss.test.js
PASS lint packages/browserify/test/watchify.test.js
PASS lint packages/rollup-rewriter/rewriter.js
  ● Console

    console.warn 
      
      /home/travis/build/tivac/modular-css/packages/rollup-rewriter/rewriter.js
        46:34  warning  'imports' is assigned a value but never used  no-unused-vars
      
      ✖ 1 problem (0 errors, 1 warning)
      

PASS lint packages/rollup/chunker.js
PASS lint packages/scratchpad/chunks.js
PASS lint packages/processor/plugins/composition.js
PASS lint packages/processor/plugins/scoping.js
PASS lint packages/processor/plugins/values-replace.js
PASS lint packages/webpack/plugin.js
PASS lint packages/aliases/test/aliases.test.js
PASS lint packages/processor/test/scoping.test.js
PASS lint packages/browserify/test/issue-58.test.js
PASS lint packages/processor/test/keyframes.test.js
PASS lint packages/browserify/test/issue-313.test.js
PASS lint packages/cli/test/cli.test.js
PASS lint packages/paths/test/paths.test.js
PASS lint packages/processor/plugins/externals.js
PASS lint packages/processor/test/externals.test.js
PASS lint packages/processor/plugins/graph-nodes.js
PASS lint packages/webpack/loader.js
PASS lint packages/cli/cli.js
PASS lint packages/browserify/test/issue-105.test.js
  ● Console

    console.warn 
      
      /home/travis/build/tivac/modular-css/packages/browserify/test/issue-105.test.js
        16:13  warning  Skipped test  jest/no-disabled-tests
        23:13  warning  Skipped test  jest/no-disabled-tests
      
      ✖ 2 problems (0 errors, 2 warnings)
      

PASS lint packages/processor/test/getters.test.js
PASS lint packages/scratchpad/test/chunks.test.js
PASS lint packages/www/build/html/guide.js
PASS lint packages/www/build/rollup-plugin-postcss.js
PASS lint packages/namer/test/namer.test.js
PASS lint packages/www/build/html/repl.js
PASS lint packages/glob/test/glob.test.js
PASS lint packages/postcss/postcss.js
PASS lint packages/www/build/rollup-plugin-generate-html.js
PASS lint packages/processor/test/exports.test.js
PASS lint packages/namer/namer.js
PASS lint packages/www/build/html/changelog.js
PASS lint packages/processor/test/issues/issue-191.test.js
PASS lint packages/www/build/html/home.js
PASS lint packages/processor/test/issues/issue-56.test.js
PASS lint packages/processor/test/issues/issue-24.test.js
PASS lint packages/www/build/html/css.js
PASS lint packages/processor/test/issues/issue-98.test.js
PASS lint packages/processor/plugins/values-local.js
PASS lint packages/processor/plugins/values-composed.js
PASS lint packages/processor/plugins/values-namespaced.js
PASS lint packages/processor/plugins/values-imported.js
PASS lint packages/www/build/svelte.js
PASS lint packages/scratchpad/chunktest.js
  ● Console

    console.warn 
      
      /home/travis/build/tivac/modular-css/packages/scratchpad/chunktest.js
        37:1   warning  Unexpected console statement  no-console
        40:5   warning  Unexpected console statement  no-console
        43:20  warning  Unexpected console statement  no-console
        46:1   warning  Unexpected console statement  no-console
      
      ✖ 4 problems (0 errors, 4 warnings)
      

PASS lint packages/processor/plugins/values-export.js
PASS lint packages/scratchpad/test/construct.js
PASS lint packages/www/build/rollup-plugin-sirv.js
PASS lint packages/processor/plugins/keyframes.js
PASS lint packages/rollup-rewriter/formats/amd.js
PASS lint packages/processor/test/unicode.test.js
PASS lint packages/aliases/aliases.js
PASS lint packages/processor/lib/graph-tiers.js
PASS lint packages/rollup-rewriter/formats/system.js
PASS lint packages/glob/glob.js
PASS lint packages/test-utils/logs.js
PASS lint packages/processor/lib/resolve.js
PASS lint packages/processor/lib/output.js
PASS lint packages/test-utils/rollup-build-snapshot.js
PASS lint packages/processor/test/issues/issue-66.test.js
PASS lint packages/processor/test/issues/issue-261.test.js
PASS lint packages/www/src/repl/listen.js
PASS lint packages/www/build/rollup-plugin-add-watch-files.js
PASS lint packages/test-utils/rollup-code-snapshot.js
PASS lint packages/processor/lib/identifiers.js
PASS lint packages/test-utils/read-dir.js
PASS lint packages/paths/paths.js
PASS lint packages/browserify/test/lib/bundle.js
PASS lint packages/scratchpad/test/snapshot.js
PASS lint packages/processor/lib/normalize.js
PASS lint packages/rollup-rewriter/formats/es.js
PASS lint packages/test-utils/relative.js
PASS lint packages/test-utils/write.js
PASS lint packages/test-utils/rollup-watching.js
PASS lint packages/processor/lib/message.js
PASS lint packages/www/src/repl/data/prompt.js
PASS lint packages/www/build/rollup-plugin-clean.js
PASS lint packages/www/build/environment.js
PASS lint packages/processor/lib/relative.js
PASS lint packages/www/stubs/path.js
PASS lint packages/www/build/html/markdown.js
PASS lint packages/test-utils/read.js
PASS lint packages/test-utils/exists.js
PASS lint packages/www/src/repl/codemirror.js
PASS lint packages/test-utils/warn.js
PASS lint packages/test-utils/prefix.js
PASS lint packages/test-utils/namer.js
PASS lint packages/www/stubs/fs.js
PASS lint packages/www/src/repl/index.js
PASS tests packages/rollup/test/rollup.test.js
PASS tests packages/processor/test/options.test.js
PASS tests packages/processor/test/api.test.js
PASS tests packages/rollup/test/splitting.test.js
PASS tests packages/rollup/test/watch.test.js
PASS tests packages/svelte/test/svelte.test.js
(node:5778) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
PASS tests packages/webpack/test/webpack.test.js
PASS tests packages/browserify/test/factor-bundle.test.js
PASS tests packages/browserify/test/browserify.test.js
PASS tests packages/processor/test/composition.test.js
PASS tests packages/processor/test/values.test.js
PASS tests packages/rollup-rewriter/test/rewriter.test.js
PASS tests packages/postcss/test/postcss.test.js
FAIL tests packages/browserify/test/watchify.test.js (5.34s)
  ● /browserify.js › watchify › shouldn't explode on invalid CSS

    Timeout - Async callback was not invoked within the 5000ms timeout specified by jest.setTimeout.

      54 |         });
      55 | 
    > 56 |         it("shouldn't explode on invalid CSS", (done) => {
         |         ^
      57 |             const build = browserify();
      58 |             let wait;
      59 | 

      at Spec (node_modules/jest-jasmine2/build/jasmine/Spec.js:92:20)
      at Suite.it (packages/browserify/test/watchify.test.js:56:9)
      at Suite.describe (packages/browserify/test/watchify.test.js:11:5)
      at Object.describe (packages/browserify/test/watchify.test.js:10:1)

PASS tests packages/aliases/test/aliases.test.js
PASS tests packages/processor/test/scoping.test.js
/home/travis/build/tivac/modular-css/node_modules/readdirp/readdirp.js:49
    var api          =  require('./stream-api')();
                                               ^

TypeError: require(...) is not a function
    at readdir (/home/travis/build/tivac/modular-css/node_modules/readdirp/readdirp.js:49:48)
    at FSWatcher.<anonymous> (/home/travis/build/tivac/modular-css/node_modules/chokidar/lib/nodefs-handler.js:355:5)
    at /home/travis/build/tivac/modular-css/node_modules/chokidar/lib/nodefs-handler.js:411:7
    at /home/travis/build/tivac/modular-css/node_modules/chokidar/lib/nodefs-handler.js:54:5
    at Array.forEach (<anonymous>)
    at fsWatchBroadcast (/home/travis/build/tivac/modular-css/node_modules/chokidar/lib/nodefs-handler.js:53:36)
    at FSWatcher.handleEvent (/home/travis/build/tivac/modular-css/node_modules/chokidar/lib/nodefs-handler.js:25:5)
    at FSWatcher.emit (events.js:197:13)
    at FSEvent.FSWatcher._handle.onchange (internal/fs/watchers.js:131:12)
npm ERR! Test failed.  See above for more details.
TravisBuddy Request Identifier: 1cd14a70-2cbd-11e9-b3d3-256864349aa7
@codecov

This comment has been minimized.

Copy link

commented Feb 9, 2019

Codecov Report

Merging #566 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          49       49           
  Lines        1176     1176           
  Branches      183      183           
=======================================
  Hits         1164     1164           
  Misses         12       12
Impacted Files Coverage Δ
packages/rollup-rewriter/rewriter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c429e...fa9b5e1. Read the comment docs.

@tivac tivac merged commit 39c11d5 into master Feb 9, 2019

2 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details

@tivac tivac deleted the netlify branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.