Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: walk invalidated dependencies #573

Merged
merged 1 commit into from Mar 28, 2019
Merged

fix: walk invalidated dependencies #573

merged 1 commit into from Mar 28, 2019

Conversation

@tivac
Copy link
Owner

@tivac tivac commented Mar 28, 2019

Description

When invalidation was added in #532 I apparently forgot to account for it withiin the dependency walking code, so invalidated files wouldn't ever be rewalked.

Motivation and Context

This has likely been causing a variety of nasty-to-debug errors in the wild 馃槥

How Has This Been Tested?

See #572, the added test in watch.test.js is how I discovered this was broken.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
When invalidation was added in #532 I apparently forgot to account for it withiin the dependency walking code, so invalidated files wouldn't ever be rewalked. This has likely been causing a variety of nasty-to-debug errors in the wild 馃槥
@tivac
Copy link
Owner Author

@tivac tivac commented Mar 28, 2019

This should also help with #571 and I think in combination with #574 that problem should be solved, I'll leave it open until I've given it some time to bake though.

Loading

@tivac tivac merged commit 0284b11 into master Mar 28, 2019
6 of 7 checks passed
Loading
@tivac tivac deleted the walk-invalidated-deps branch Mar 28, 2019
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Mar 28, 2019

Hey @tivac,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 44953520-5130-11e9-977c-5d859f4a0935

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants