Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): better error details #579

Merged
merged 8 commits into from Apr 9, 2019

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented Apr 8, 2019

Description

Show the postcss error.toString() output in rollup & svelte errors since it's way more descriptive than the default error.message.

Motivation and Context

Fixes #578

How Has This Been Tested?

Added tests, verified it outputs useful errors

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tivac added some commits Apr 8, 2019

feat(rollup): expose nice postcss errors
Instead of the garbage useless default ones.
fix(svelte): set error message to full .toString() output
Makes for a nicer debugging experience
chore(lint): update how newlines are treated
Since apparently an ESLint upgrade started causing some weird results?
fix(rollup): send along the entire original error
Just overwrite .message w/ the value of .toString() since it's more useful

@tivac tivac self-assigned this Apr 8, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 8, 2019

Codecov Report

Merging #579 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #579      +/-   ##
=========================================
+ Coverage   98.89%   98.9%   +<.01%     
=========================================
  Files          47      47              
  Lines        1178    1188      +10     
  Branches      183     183              
=========================================
+ Hits         1165    1175      +10     
  Misses         13      13
Impacted Files Coverage Δ
packages/svelte/svelte.js 100% <100%> (ø) ⬆️
packages/rollup/rollup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 643955c...58c281e. Read the comment docs.

@tivac tivac merged commit 15da7ff into master Apr 9, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 98.89%)
Details
codecov/project 98.9% (+<.01%) compared to 643955c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@tivac tivac deleted the rollup-error-details branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.