Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove true-case-path #582

merged 10 commits into from May 8, 2019


None yet
1 participant
Copy link

commented May 7, 2019


Removing true-case-path package from @modular-css/processor and replaced it with a new dupewarn option that defaults to true.

Motivation and Context

Fixes #581, adding a warning and removing the checks entirely is simpler and reasonably safe for all the cases that caused true-case-path to be added in the first place (#191, #527)

How Has This Been Tested?

Added tests to make sure the warning correctly triggers and can be disabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.


tivac added some commits May 7, 2019

@tivac tivac self-assigned this May 7, 2019


This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

Merging #582 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #582      +/-   ##
+ Coverage    98.9%   98.92%   +0.01%     
  Files          47       48       +1     
  Lines        1191     1211      +20     
  Branches      183      184       +1     
+ Hits         1178     1198      +20     
  Misses         13       13
Impacted Files Coverage Δ
packages/rollup-rewriter/formats/amd.js 92.85% <100%> (+3.96%) ⬆️
packages/rollup-rewriter/rewriter.js 100% <100%> (ø) ⬆️
packages/processor/processor.js 100% <100%> (ø) ⬆️
packages/processor/lib/normalize.js 100% <100%> (ø) ⬆️
packages/test-utils/case-sensitive-fs.js 100% <100%> (ø)
packages/test-utils/read-dir.js 100% <100%> (ø) ⬆️
packages/processor/lib/resolve.js 100% <100%> (ø) ⬆️
packages/rollup-rewriter/formats/system.js 91.66% <100%> (+2.77%) ⬆️
packages/rollup-rewriter/formats/es.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06ec9b...445301b. Read the comment docs.

tivac added some commits May 8, 2019

refactor(processor): resolve doesn't need to throw
Let consumers do that instead, they can provide better errors anyways.

@tivac tivac merged commit 01581f9 into master May 8, 2019

6 of 9 checks passed

Header rules No header rules processed
Pages changed 1 new file uploaded
Redirect rules No redirect rules processed
Mixed content No mixed content detected
codecov/patch 100% of diff hit (target 98.9%)
codecov/project 98.92% (+0.01%) compared to a06ec9b
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
deploy/netlify Deploy preview ready!

@tivac tivac deleted the async-normalize branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.