Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): properly include dependencies #602

Merged
merged 1 commit into from May 29, 2019

Conversation

Projects
None yet
1 participant
@tivac
Copy link
Owner

commented May 29, 2019

Description

Instead of injecting import statements use this.addWatchFile(<file>) like rollup intended.

Motivation and Context

Solves some weird chunking issues I was seeing and is generally way more correct across the board.

How Has This Been Tested?

Existing tests around chunking and watching still pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
fix(rollup): properly include dependencies
Instead of injecting `import` statements use `this.addWatchFile(<file>)` like rollup intended. Solves some weird chunking issues I was seeing and is generally **way** more correct across the board.

@tivac tivac self-assigned this May 29, 2019

@codecov

This comment has been minimized.

Copy link

commented May 29, 2019

Codecov Report

Merging #602 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files          48       48           
  Lines        1211     1211           
  Branches      184      184           
=======================================
  Hits         1198     1198           
  Misses         13       13
Impacted Files Coverage Δ
packages/rollup/rollup.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692da74...21b9d70. Read the comment docs.

@tivac tivac merged commit c581e3d into master May 29, 2019

4 of 9 checks passed

Header rules Deploy failed
Details
Mixed content Deploy failed
Details
Pages changed Deploy failed
Details
Redirect rules Deploy failed
Details
deploy/netlify Deploy preview failed.
Details
codecov/patch 100% of diff hit (target 98.92%)
Details
codecov/project 98.92% (+0%) compared to 692da74
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tivac tivac deleted the rollup-dependencies-v999 branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.