Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @composes rule support #635

Merged
merged 7 commits into from Jul 6, 2019

Conversation

Projects
None yet
2 participants
@tivac
Copy link
Owner

commented Jul 4, 2019

Description

Implementing the idea from #633, but renamed to @composes because it's a concept already prevalent in modular-css so it seems like a good fit.

Motivation and Context

Fixes #633, which also explains why this is probably a good idea. It could be a terrible plan too, I dunno!

How Has This Been Tested?

Added tests & ensured code coverage looked good. I'm sure this first pass is missing featured but I'll get it there once I start using it for real.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tivac tivac changed the title Add @composes rule Add @composes support Jul 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 4, 2019

Codecov Report

Merging #635 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage      99%   99.02%   +0.01%     
==========================================
  Files          48       49       +1     
  Lines        1209     1230      +21     
  Branches      184      187       +3     
==========================================
+ Hits         1197     1218      +21     
  Misses         12       12
Impacted Files Coverage Δ
packages/processor/plugins/composition.js 100% <100%> (ø) ⬆️
packages/processor/processor.js 100% <100%> (ø) ⬆️
packages/processor/plugins/graph-nodes.js 100% <100%> (ø) ⬆️
packages/processor/plugins/at-composes.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6fb0d...98c5580. Read the comment docs.

@tivac tivac changed the title Add @composes support Add @composes rule support Jul 4, 2019

@tivac tivac force-pushed the composes-at-rule branch from 01e60a6 to 125a9dc Jul 4, 2019

@TravisBuddy

This comment has been minimized.

Copy link

commented Jul 4, 2019

Hey @tivac,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 54ac9690-9e2b-11e9-80b6-37a8a59c6ad9

tivac added some commits Jul 6, 2019

docs: shuffling around
Swapped around some ordering of things to make more sense, and also made dangerous things less prominent.
docs: renaming a few sections
Also clarified @values a bit

@tivac tivac merged commit 27d696a into master Jul 6, 2019

6 of 9 checks passed

Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 99%)
Details
codecov/project 99.02% (+0.01%) compared to 9f6fb0d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@tivac tivac deleted the composes-at-rule branch Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.