Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stylelint-config): add @modular-css/stylelint-config package #637

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@tivac
Copy link
Owner

commented Jul 9, 2019

Description

Adding a new package, @modular-css/stylelint-config to make it easy to have stylelint ignore the modular-css custom syntax using its extends support.

Motivation and Context

I don't want to keep on having to do this manually every time I start a new project using stylelint & modular-css.

How Has This Been Tested?

Been using these properties as part of our broader stylelint config on a project for over a year. Extracted from that and then tested within that project.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Provides a basic stylelint config that can be used with the `extends` feature in stylelint to easily prevent it from barfing on modular-css features.
@tivac tivac added the feature label Jul 9, 2019
@tivac tivac self-assigned this Jul 9, 2019
@codecov

This comment has been minimized.

Copy link

commented Jul 9, 2019

Codecov Report

Merging #637 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #637   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          46       46           
  Lines        1150     1150           
  Branches      174      174           
=======================================
  Hits         1140     1140           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76bb5d...d54ebd0. Read the comment docs.

@tivac tivac merged commit bc3b711 into master Aug 12, 2019
4 of 9 checks passed
4 of 9 checks passed
Header rules Deploy failed
Details
Mixed content Deploy failed
Details
Pages changed Deploy failed
Details
Redirect rules Deploy failed
Details
deploy/netlify Deploy preview failed.
Details
codecov/patch Coverage not affected when comparing f76bb5d...d54ebd0
Details
codecov/project 99.13% remains the same compared to f76bb5d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tivac tivac deleted the stylelint-config branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.