Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processor): allow composes anywhere in a rule #646

Merged
merged 3 commits into from Aug 12, 2019

Conversation

@tivac
Copy link
Owner

commented Aug 12, 2019

Description

BREAKING CHANGE: previously modular-css would require that composes be the first declaration in a rule. This restriction has been removed due to better solutions for enforcing that behavior existing now (stylelint-order).

Motivation and Context

Fixes #645

How Has This Been Tested?

Tests! Also gonna poke at it in the REPL once the PR goes up.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Fixes #645

BREAKING CHANGE: previously `modular-css` would require that `composes` be the first declaration in  a rule. This restriction has been removed due to better solutions for enforcing that behavior existing now (stylelint-order).
@tivac tivac self-assigned this Aug 12, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 12, 2019

Codecov Report

Merging #646 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
- Coverage   99.13%   99.12%   -0.01%     
==========================================
  Files          46       46              
  Lines        1150     1143       -7     
  Branches      174      173       -1     
==========================================
- Hits         1140     1133       -7     
  Misses         10       10
Impacted Files Coverage Δ
packages/processor/plugins/composition.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3b711...8e47c84. Read the comment docs.

@tivac tivac merged commit 31b57a2 into master Aug 12, 2019
4 of 7 checks passed
4 of 7 checks passed
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@tivac tivac deleted the compose-wherever-idgaf branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.