Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-rewriter): let loader option be a function #667

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@tivac
Copy link
Owner

commented Sep 11, 2019

Description

Let the loader option be either a string or a function.

Motivation and Context

Allows for picking a file out of the bundle to be used, even if the output name is hashed by rollup.

How Has This Been Tested?

Added tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Allows for picking a file out of the bundle to be used, even if the output name is hashed by rollup.
@tivac tivac added the feature label Sep 11, 2019
@tivac tivac self-assigned this Sep 11, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 11, 2019

Codecov Report

Merging #667 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   99.12%   99.12%   +<.01%     
==========================================
  Files          45       45              
  Lines        1138     1139       +1     
  Branches      173      174       +1     
==========================================
+ Hits         1128     1129       +1     
  Misses         10       10
Impacted Files Coverage Δ
packages/rollup-rewriter/rewriter.js 100% <100%> (ø) ⬆️
packages/rollup-rewriter/formats/es.js 100% <100%> (ø) ⬆️
packages/rollup-rewriter/formats/amd.js 92.85% <100%> (ø) ⬆️
packages/rollup-rewriter/formats/system.js 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d81d3f...cdfdc30. Read the comment docs.

@tivac tivac changed the title feat(rollup-rewriter): let loader be a fn feat(rollup-rewriter): let loader option be a function Sep 11, 2019
@tivac tivac merged commit a57cddf into master Sep 11, 2019
7 of 10 checks passed
7 of 10 checks passed
triage
Details
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
codecov/patch 100% of diff hit (target 99.12%)
Details
codecov/project 99.12% (+<.01%) compared to 6d81d3f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@tivac tivac deleted the rewriter-loader-fn branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.