Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to suppress value export #673

Merged
merged 1 commit into from Sep 23, 2019

Conversation

@lunsdorf
Copy link
Contributor

commented Sep 21, 2019

Description

Implements options to disable value export, as mentioned in #672.

Motivation and Context

How Has This Been Tested?

Added unit test for option.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@tivac
tivac approved these changes Sep 22, 2019
Copy link
Owner

left a comment

Looks good! I'll try and get this merged tomorrow, thanks for tackling it.

packages/processor/test/options.test.js Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

commented Sep 22, 2019

Codecov Report

Merging #673 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #673   +/-   ##
=======================================
  Coverage   98.43%   98.43%           
=======================================
  Files          45       45           
  Lines        1152     1152           
  Branches      178      178           
=======================================
  Hits         1134     1134           
  Misses         15       15           
  Partials        3        3
Impacted Files Coverage Δ
packages/processor/processor.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8ea56...1cc4441. Read the comment docs.

@tivac tivac changed the title feat: option to suppress value export (#672) feat: option to suppress value export Sep 23, 2019
@tivac tivac merged commit 97a5b1e into tivac:master Sep 23, 2019
2 of 7 checks passed
2 of 7 checks passed
triage
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
@lunsdorf

This comment has been minimized.

Copy link
Contributor Author

commented Sep 23, 2019

Nice! Thanks a lot for the the quick response and actually integrating it.

@tivac

This comment has been minimized.

Copy link
Owner

commented Sep 23, 2019

Released in v25.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.