Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultExport flag for webpack loader #680

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@plesiecki
Copy link
Contributor

@plesiecki plesiecki commented Oct 28, 2019

Adds option to disable default export in Webpack bundle.

Description

Adds a check before adding export default ... to the Webpack bundle.

Motivation and Context

This value is not always needed, and removing it can reduce the bundle size.

How Has This Been Tested?

I guess unit is enough

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@netlify
Copy link

@netlify netlify bot commented Oct 28, 2019

Deploy preview for m-css failed.

Built with commit 172ace0

https://app.netlify.com/sites/m-css/deploys/5db6f4c92d2328000ca9b38a

@codecov
Copy link

@codecov codecov bot commented Oct 28, 2019

Codecov Report

Merging #680 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   98.43%   98.44%   +<.01%     
==========================================
  Files          45       45              
  Lines        1152     1154       +2     
  Branches      178      179       +1     
==========================================
+ Hits         1134     1136       +2     
  Misses         15       15              
  Partials        3        3
Impacted Files Coverage Δ
packages/webpack/loader.js 93.1% <100%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5789b89...172ace0. Read the comment docs.

@tivac
Copy link
Owner

@tivac tivac commented Oct 28, 2019

This looks great, thanks!

@tivac tivac merged commit 0179f99 into tivac:master Oct 28, 2019
3 of 9 checks passed
@plesiecki
Copy link
Contributor Author

@plesiecki plesiecki commented Oct 28, 2019

Thanks 🤟

@plesiecki
Copy link
Contributor Author

@plesiecki plesiecki commented Oct 29, 2019

Looking forward to new release

@tivac
Copy link
Owner

@tivac tivac commented Oct 30, 2019

This is released in @modular-css/webpack@25.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants