Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processor): add processor.resolve() #681

merged 6 commits into from Oct 29, 2019

feat(processor): add processor.resolve() #681

merged 6 commits into from Oct 29, 2019


Copy link

@tivac tivac commented Oct 29, 2019


Exposed previously private(ish) processor._resolve() as processor.resolve() so it's obvious that it's fine and reasonable for consumers to use it.

Motivation and Context

Fixes #679 by allowing the svelte preprocessor to use the exact same file resolution logic as the core modular-css package.

How Has This Been Tested?

Added a new svelte test, all existing tests still pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Copy link

@netlify netlify bot commented Oct 29, 2019

Deploy preview for m-css failed.

Built with commit c81ee19

@tivac tivac force-pushed the processor-resolve branch from ee17c65 to c81ee19 Oct 29, 2019
Copy link

@codecov codecov bot commented Oct 29, 2019

Codecov Report

Merging #681 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #681   +/-   ##
  Coverage   98.44%   98.44%           
  Files          45       45           
  Lines        1154     1154           
  Branches      179      179           
  Hits         1136     1136           
  Misses         15       15           
  Partials        3        3
Impacted Files Coverage Δ
packages/processor/processor.js 100% <100%> (ø) ⬆️
packages/svelte/svelte.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b3c50...adc139a. Read the comment docs.

tivac added 6 commits Oct 29, 2019
And update the tests that were already using the `._resolve()` version.
Fixes #679 by allowing the svelte preprocessor to use the same file resolution logic that the modular-css processor is using.
Travis already does it, and it's mostly noise.
@tivac tivac force-pushed the processor-resolve branch from c81ee19 to adc139a Oct 29, 2019
@tivac tivac merged commit 2c5a51d into master Oct 29, 2019
10 checks passed
@tivac tivac deleted the processor-resolve branch Oct 29, 2019
Copy link
Owner Author

@tivac tivac commented Oct 30, 2019

This is released in @modular-css/core@25.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant