Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename & deconflict together #820

Merged
merged 3 commits into from
Apr 8, 2022
Merged

fix: rename & deconflict together #820

merged 3 commits into from
Apr 8, 2022

Conversation

tivac
Copy link
Owner

@tivac tivac commented Apr 8, 2022

@Morklympious found a bug where if you exercise both the renaming & deconflicting logic the rename (via identifierfy) gets lost and the resulting variable name is no longer valid.

So now it's fixed.

@Morklympious found a bug where if you exercise both the renaming & deconflicting logic the rename (via `identifierfy`) gets lost and the resulting variable name is no longer valid.

So now it's fixed.
@ghost
Copy link

ghost commented Apr 8, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Apr 8, 2022

Deploy Preview for m-css ready!

Name Link
🔨 Latest commit 83fdf8b
🔍 Latest deploy log https://app.netlify.com/sites/m-css/deploys/624fd2e89f62250009da4dab
😎 Deploy Preview https://deploy-preview-820--m-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #820 (83fdf8b) into main (a636c9b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #820   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          37       37           
  Lines        1434     1435    +1     
  Branches      232      232           
=======================================
+ Hits         1428     1429    +1     
  Misses          6        6           
Impacted Files Coverage Δ
packages/css-to-js/css-to-js.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a636c9b...83fdf8b. Read the comment docs.

@tivac tivac merged commit ea6a0e9 into main Apr 8, 2022
@tivac tivac deleted the value-camelcasing branch April 8, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant