-
Notifications
You must be signed in to change notification settings - Fork 19
fix(rollup): generated JS always uses clean names #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Otherwise there's no way to track the locally-unique name for each selector within the file.
👇 Click on the image for a new way to code review
Legend |
✅ Deploy Preview for m-css ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think I over-complicated this
If the ESM export is always tidied up (it is) then we can always apply the same tidying to the import.
Codecov Report
@@ Coverage Diff @@
## main #847 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 37 37
Lines 1435 1439 +4
Branches 232 232
=======================================
+ Hits 1429 1433 +4
Misses 6 6
Continue to review full report at Codecov.
|
Description
Adding in an extra layer of tracking of renamed/uniqued variables so that they're always used instead of raw classnames, for instances where that isn't a valid JS identifier that can be safely exported/imported.
Motivation and Context
Fixes #846
How Has This Been Tested?
Wrote tests for it.
Types of changes
Checklist: