Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't move composed classes early #856

Merged
merged 5 commits into from
Jun 15, 2022
Merged

fix: don't move composed classes early #856

merged 5 commits into from
Jun 15, 2022

Conversation

tivac
Copy link
Owner

@tivac tivac commented Jun 15, 2022

Because it can cause invalid output if they get moved ahead of their dependencies, and we don't need to handle them at this point anyways.

Because it can cause invalid output if they get moved ahead of their dependencies, and we don't need to handle them at this point anyways
@ghost
Copy link

ghost commented Jun 15, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Jun 15, 2022

Deploy Preview for m-css ready!

Name Link
🔨 Latest commit 69dd550
🔍 Latest deploy log https://app.netlify.com/sites/m-css/deploys/62a98603d30c6a0009134ac8
😎 Deploy Preview https://deploy-preview-856--m-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #856 (69dd550) into main (dc476ef) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   99.58%   99.58%   -0.01%     
==========================================
  Files          37       37              
  Lines        1439     1437       -2     
  Branches      232      231       -1     
==========================================
- Hits         1433     1431       -2     
  Misses          6        6              
Impacted Files Coverage Δ
packages/css-to-js/css-to-js.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc476ef...69dd550. Read the comment docs.

@tivac tivac merged commit 00e84c8 into main Jun 15, 2022
@tivac tivac deleted the ignore-local-deps branch June 15, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant