Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for renderToStaticNodeStream/rendertostaticmarkup #15

Closed
jamesjjk opened this issue Nov 30, 2017 · 4 comments
Closed

Support for renderToStaticNodeStream/rendertostaticmarkup #15

jamesjjk opened this issue Nov 30, 2017 · 4 comments

Comments

@jamesjjk
Copy link

@tizmagik

I'm adding an option to remove [data-reactroot=""] from the queryselector string so your library supports both static stream and static markup. Like the simplicity of what you have done!

@tizmagik
Copy link
Owner

Ah good idea, hadn’t considered that! Thanks 😁

@tizmagik
Copy link
Owner

I think I'm going to solve this by passing in a custom data attribute specific to react-head. So something like [data-rh=""] so that regardless of the rendering method used, react-head will know which head tags it placed and then can remove/update them on the client safely. Thoughts?

@Maarten88
Copy link

That is the same change I made, it worked well for me.

@jamesjjk
Copy link
Author

Closing in favour of solution #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants