-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escaping selector strings #16
Comments
Good call, yes. Would you be up for submitting a PR? |
I have provided a PR for both #14 and Escaping strings. Please note that the build directory is included |
@jamesjjk I left the escaping out in the recent PR. I wanted to make sure I understand the use case for this first and have a test for it. Do you have an example of a real world use case you hit for this? Also happy to accept a separate PR if you’re up for it. Thanks! |
@tizmagik Use case is for example a title with a double quote mark. |
This is now fixed with the latest v3.0.0 release. Please feel free to open a new issue if there's still any problems. |
@tizmagik
Hey you should consider also escaping selector strings:
The text was updated successfully, but these errors were encountered: