Escaping selector strings

[jamesjjk]

@tizmagik

Hey you should consider also escaping selector strings:

/* eslint no-useless-escape:0 */
const buildSelector = obj =>
  Object.keys(obj)
    .map(k => {
      const cnt = obj[k].replace(/["\\]/g, '\\$&');
      return `[${k}="${cnt}"]`;
    })
    .join('');

export default buildSelector;

[tizmagik]

Good call, yes. Would you be up for submitting a PR?

[jamesjjk]

I have provided a PR for both #14 and Escaping strings. Please note that the build directory is included

[tizmagik]

@jamesjjk I left the escaping out in the recent PR. I wanted to make sure I understand the use case for this first and have a test for it. Do you have an example of a real world use case you hit for this? Also happy to accept a separate PR if you’re up for it.

Thanks!

[jamesjjk]

@tizmagik Use case is for example a title with a double quote mark.

[tizmagik]

This is now fixed with the latest v3.0.0 release. Please feel free to open a new issue if there's still any problems.