Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity Scan (CID 1352359) [/player/src/tizgraphutil.cpp:set_role] : Out-of-bounds write #203

Closed
tizonia opened this issue Mar 6, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@tizonia
Copy link
Owner

commented Mar 6, 2016

  • CID : 1352359
  • Type : Out-of-bounds write
  • Impact : High
  • Status : New
  • First Detected : 02/29/16
  • Classification : Unclassified
  • Severity : Unspecified
  • Component : player
  • Category : Memory - corruptions
  • File : /player/src/tizgraphutil.cpp
  • Function : set_role
254{
255  OMX_ERRORTYPE error = OMX_ErrorNone;
256  OMX_PARAM_COMPONENTROLETYPE roletype;
257  TIZ_INIT_OMX_STRUCT (roletype);
258  strncpy ((char *)roletype.cRole, comp_role.c_str (), OMX_MAX_STRINGNAME_SIZE - 1);

CID 1352359 (#1 of 1): Out-of-bounds write (OVERRUN)
1. overrun-local: Overrunning array roletype.cRole of 128 bytes at byte offset 128 using index 128.
259  roletype.cRole[OMX_MAX_STRINGNAME_SIZE] = '\000';
260  tiz_check_omx_err (OMX_SetParameter (
261      handle, OMX_IndexParamStandardComponentRole, &roletype));
262
263  return error;
264}

@tizonia tizonia added the bug label Mar 6, 2016

@juanrubio juanrubio closed this in 55cc0c2 Apr 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.