Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pluginsdir variable in pkg-config file. #248

Closed
gpalsingh opened this issue Jul 11, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@gpalsingh
Copy link
Contributor

commented Jul 11, 2016

Hi,
I am working on switching the mesa/gallium OpenMAX state tracker from bellagio to Tizonia as a potential X.Org EVoC student.
I noticed that mesa uses the pluginsdir variable to set the install location of libomx_mesa.so file. But Tizonia does not provide this variable which is necessary to make any further progress.
I have installed tizonia using apt because compiling from source crashes my PC halfway through.
Thanks

@juanrubio

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2016

Hi!

I was wondering if you would be able to elaborate a bit. Maybe you could point me to the mesa sources that make pluginsdir a requirement?.

Wrt compilation, compiling Tizonia from top-level involves the compilation of the 'player' application (C++, boost, etc, i.e. difficult to compile). You don't need to build this for your work in Mesa. I've created #249 for this, but in the meantime you can simply remove this sub-project from the top-level configure.ac and Makefile.am files.

@gpalsingh

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2016

The variable is used in configure.ac at line 2252:
https://cgit.freedesktop.org/mesa/mesa/tree/configure.ac#n2252

For now I am using the libdir variable as I saw that tizonia installs the plugins in libdir only.

@juanrubio

This comment has been minimized.

Copy link
Collaborator

commented Jul 20, 2016

I see. It looks like this is specific to Bellagio. See here:

https://bugs.freedesktop.org/show_bug.cgi?id=80615

And this patch:
https://patchwork.freedesktop.org/patch/33916/

So mesa seems to be adapted to whatever Bellagio used at the time (in this case 'pluginsdir') to identify the location of the OMX components.

So I wonder if it would actually make more sense to add a separate option for Tizonia, to allow that to co-exist with the existing "with-omx-libdir"...

....but not sure though.

I need to look more into this.

@juanrubio

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2016

IL Components are now installed under ${libdir}/tizonia0-plugins12

+# Define location of plugin directory
 +AS_AC_EXPAND(PLUGINDIR, ${libdir}/tizonia0-plugins12)
 +AC_DEFINE_UNQUOTED(PLUGINDIR, "$PLUGINDIR",
 +  [Directory where Tizonia plugins are located])
 +AC_MSG_NOTICE([Using $PLUGINDIR as the components install location])
 +# Define plugin directory configure-time variable
 +AC_SUBST([plugindir], ['${libdir}/tizonia0-plugins12'])

Also the il core pkgconfig file has been updated to include a "pluginsdir" variable:

exec_prefix=@exec_prefix@
libdir=@libdir@       
includedir=@includedir@
+pluginsdir=@libdir@/tizonia0-plugins12

Name: libtizcore
Description: Tizonia OpenMAX IL 1.2 Core

Note that in Tizonia currently there is no 'tizonia.pc', that is why the 'pluginsdir' variable has been added to libtizcore.pc. If necessary, we could add a tizonia.pc in one of the debian packages (tizonia-config possibly).

@juanrubio

This comment has been minimized.

Copy link
Collaborator

commented Jan 14, 2017

I believe this can be closed now.

@juanrubio juanrubio closed this Jan 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.