Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Music: track downloading is interrupted seemingly randomly #349

Closed
juanrubio opened this issue Jul 3, 2017 · 1 comment
Closed

Google Music: track downloading is interrupted seemingly randomly #349

juanrubio opened this issue Jul 3, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@juanrubio
Copy link
Member

@juanrubio juanrubio commented Jul 3, 2017

This issue is related to #337, which essentially delivered a workaround.

It looks like some Google servers may be closing down the connection after 90 seconds. I.e. if the track has not been fully downloaded within 90 seconds, libcurl will find the connection closed. #377 introduced an EOS event when this occurs, which will make the player jump to the next song, as a workaround to the stalling situation in #337.

It looks like a more appropriate solution would be to make the http_source component buffer the whole track before the 90 second period is over.

This Google Play Music peculiarity has been recently documented in simon-weber/gmusicapi#548 and home-assistant-libs/pychromecast#175

@juanrubio juanrubio added the bug label Jul 3, 2017
@juanrubio juanrubio added this to the v0.9.0 milestone Jul 3, 2017
@juanrubio juanrubio self-assigned this Jul 3, 2017
@juanrubio juanrubio changed the title Google Music: track downloading is interrupted seemingly randmoly Google Music: track downloading is interrupted seemingly randomly Jul 3, 2017
@juanrubio juanrubio added this to the v0.10.0 milestone Aug 28, 2017
@juanrubio juanrubio removed this from the v0.9.0 milestone Aug 28, 2017
@juanrubio juanrubio removed this from the v0.10.0 milestone Oct 22, 2017
@juanrubio juanrubio added this to the v0.11.0 milestone Oct 22, 2017
@tizonia tizonia removed this from the v0.11.0 milestone Feb 11, 2018
@tizonia tizonia added this to the v0.13.0 milestone Feb 11, 2018
@tizonia tizonia removed this from the v0.13.0 milestone Mar 14, 2018
@tizonia tizonia added this to the v0.14.0 milestone Mar 14, 2018
@tizonia
Copy link
Collaborator

@tizonia tizonia commented Apr 18, 2018

Closing this issue. This problem does not seem to be occurring anymore.

@tizonia tizonia closed this Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant