Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
libtizonia: nBufferSize is not updated on video output port #358
When vp8dprc.c::update_output_port_params calls "tiz_krn_SetParameter_internal" it results that the video output port does not get its nBufferSize updated. Instead only the input port has its nBufferSize recomputed.
In https://github.com/tizonia/tizonia-openmax-il/blob/master/libtizonia/src/tizkernel.c#L224 there is A) tiz_port_apply_slaving_behaviour (p_mos_port, ap_port).
Indeed here https://github.com/tizonia/tizonia-openmax-il/blob/master/libtizonia/src/tizvideoport.c#L457 it is defined like this:
The exact issue is that https://github.com/tizonia/tizonia-openmax-il/blob/master/libtizonia/src/tizvideoport.c#L485
Changing A to B fixes the issue but I guess this is wrong since this is to forward changes from one port to another. But here the nBufferSize is not copied from on port to another. It is computed: "const OMX_U32 new_buf_sz = y_sz + u_sz + v_sz; " so I am confused. Also I am confused because this is done on the bitstream port (ex: input port of a decoder).
Thx in advance for your clarifications !
So in the end we only need:
I tested that changed and it worked but I do not have the fork at the moment so please submit the change, thx a lot!