Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube: URLs are permanently deleted from the playback queue in the presence of temporary communication errors #379

Closed
juanrubio opened this issue Oct 15, 2017 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@juanrubio
Copy link
Member

@juanrubio juanrubio commented Oct 15, 2017

ERROR: Unable to download webpage: <urlopen error EOF occurred in violation of protocol (_ssl.c:590)> (caused by URLError(SSLEOFError(8, u'EOF occurred in violation of protocol (_ssl.c:590)'),))
[YouTube] Could not retrieve the audio stream URL for 'zhyaAPsT1LU' (Attempt 3 of 5).

The permanent removal of URLs from the playback queue causes the queue to become empty after a while. Temporary communication errors should not lead to URL removal.

Solution:

  • The URLs should be kept in the queue, to be retried at a later time. If any urls contain audio data that the graph can currently handle (like ogg), the stream URL will be kept, which is not ideal, but at least we won't leak URLs that have temporary resolution problems.
@juanrubio juanrubio added the bug label Oct 15, 2017
@juanrubio juanrubio added this to the v0.10.0 milestone Oct 15, 2017
@juanrubio juanrubio self-assigned this Oct 15, 2017
@juanrubio juanrubio changed the title youtube: URLs are discarded when there is a communication error with youtube servers youtube: URLs are deleted from the playback queue when a communication error with youtube servers occurs Oct 15, 2017
@juanrubio juanrubio changed the title youtube: URLs are deleted from the playback queue when a communication error with youtube servers occurs youtube: URLs are deleted from the playback queue in the presence of temporary communication errors Oct 15, 2017
@juanrubio juanrubio changed the title youtube: URLs are deleted from the playback queue in the presence of temporary communication errors youtube: URLs are permanently deleted from the playback queue in the presence of temporary communication errors Oct 15, 2017
@juanrubio juanrubio closed this in 0f0ec73 Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.