New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--gmusic-unlimited-activity plays same playlist for activity every time #507

Closed
ionyx0 opened this Issue Aug 22, 2018 · 10 comments

Comments

Projects
None yet
3 participants
@ionyx0

ionyx0 commented Aug 22, 2018

Description

When using --gmusic-unlimited-activity, the playlist that is chosen and returned from search results is the same every time.

Steps to Reproduce

  1. tizonia --gmusic-unlimited-activity working

Expected behavior: [What you expect to happen]
After executing this command, I would expect to see a list of stations to choose from or a random station from the results begin to play.
Actual behaviour: [What actually happens]
The same station (Deep focus instrumentals, in this case) plays every time.
Reproduces how often: [What percentage of the time does it reproduce?]
100%

Versions

OS:
NAME="Linux Mint"
VERSION="18.3 (Sylvia)"
ID=linuxmint
ID_LIKE=ubuntu
PRETTY_NAME="Linux Mint 18.3"
VERSION_ID="18.3"
HOME_URL="http://www.linuxmint.com/"
SUPPORT_URL="http://forums.linuxmint.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/linuxmint/"
VERSION_CODENAME=sylvia
UBUNTU_CODENAME=xenial

tizonia
tizonia 0.15.0. Copyright (C) 2018 Juan A. Rubio
This software is part of the Tizonia project http://tizonia.org

Debug Info:
* [Boost 1_58]
* [TagLib 1.9.1]
* [MediaInfoLib - v0.7.82]

Installation Method Used

APT repo and libs from pip

Additional Information

I have a paid Google Music account.

@tizonia

This comment has been minimized.

Owner

tizonia commented Aug 22, 2018

Hi!, thanks for taking the time to report this issue.

Tizonia uses fuzzy matching to select stations from the search results returned by the cloud service. The idea is to make the interaction with Tizonia on the command line as minimal as possible. So there is no way to interact with Tiizonia to select a specific station once the stations are printed on the console. But you can always modify your search term to 'help' the fuzzy matching logic select some other station the next time around.

So for example, when I type

tizonia --gmusic-unlimited-activity 'working'

I see 3 stations printed on the console, the last one being 'Office radio'. So if I cancel that and try again again with

tizonia --gmusic-unlimited-activity 'working office radio'

Tizonia makes 'Office radio' the selected station and plays its streams.

@ionyx0

This comment has been minimized.

ionyx0 commented Aug 22, 2018

So, maybe there's something else going on here... See the examples below. One using 'working' and the other using 'working office radio'. Neither of the result sets are what I would expect (music without lyrics).

tizonia --gmusic-unlimited-activity 'working'
tizonia 0.15.0. Copyright (C) 2018 Juan A. Rubio
This software is part of the Tizonia project <http://tizonia.org>

[Google Play Music] [Connecting] : '*********@gmail.com'.
/usr/local/lib/python2.7/dist-packages/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
[Google Play Music] [Authenticating] : 'with cached auth token'
[Google Play Music] [Retrieving activities] : '*********@gmail.com'. 
[Google Play Music] [Activity search in Google Play Music] : 'working'. 
[Google Play Music] [Activity] 'Deep focus instrumentals : We'll play you music (without lyrics) to help you focus. Just pick a station.'.
[Google Play Music] Playing 'Deep focus instrumentals'.
[Google Play Music] [Track] 'We Takin' Over' by 'DJ Khaled'.
[Google Play Music] [Track] 'Southside (feat. Ashanti)' by 'Lloyd'.
[Google Play Music] [Track] 'Brooklyn Zoo' by 'Ol' Dirty Bastard'.
[Google Play Music] [Track] 'Homecoming (feat. Chris Martin)' by 'Kanye West'.
[Google Play Music] [Track] 'JFK 2 LAX' by 'Gang Starr'.
[Google Play Music] [Track] 'Hustlin' (Album Version Edited)' by 'Rick Ross'.
[Google Play Music] [Track] 'Country Boyz' by 'Nappy Roots'.
[Google Play Music] [Track] 'New York, New York' by 'Tha Dogg Pound'.
[Google Play Music] [Track] 'Atlanta Zoo (feat. Ludacris)' by 'Gucci Mane'.
[Google Play Music] [Track] 'In My Hood' by '50 Cent'.
[Google Play Music] [Track] 'Old School' by '2Pac'.
[Google Play Music] [Track] 'Palmdale' by 'Afroman'.
[Google Play Music] [Track] '305 Anthem' by 'Pitbull'.
[Google Play Music] [Track] 'Southernplayalisticadillacmuzik' by 'OutKast'.
[Google Play Music] [Track] 'L.A.' by 'Murs'.
[Google Play Music] [Track] 'Welcome 2 Houston' by 'A.D.'.
[Google Play Music] [Track] 'An Open Letter To NYC' by 'Beastie Boys'.
[Google Play Music] [Track] 'Atlanta, GA (feat. Ludacris, The Dream and Gucci Mane)' by 'Shawty Lo'.
[Google Play Music] [Track] 'The Message (feat. Melle Mel & Duke Bootee)' by 'Grandmaster Flash & The Furious Five'.
[Google Play Music] [Track] 'Brooklyn Girls' by 'Charles Hamilton'.
[Google Play Music] [Track] 'Lose Yourself' by 'Eminem'.
[Google Play Music] [Track] 'Put On (Feat. Kanye West)' by 'Young Jeezy'.
[Google Play Music] [Track] '90210' by 'Wale'.
[Google Play Music] [Track] 'Boyz N Da Hood' by 'Boyz N Da Hood'.
[Google Play Music] [Track] 'Chi Town (Explicit Version)' by 'Da Brat'.
[Google Play Music] [Tracks in queue] '25'.
[Google Play Music] [Connected] : '*********@gmail.com'.
[Google Play Music] [Connected] : '*********@gmail.com'.
   DJ Khaled : We Takin' Over
     Album : We The Best
     Year : 2007
     Duration : 4m:23s
     Track # : 3
     2 Ch, 44.1 KHz, 16:s:b 
tizonia --gmusic-unlimited-activity 'working office radio'
tizonia 0.15.0. Copyright (C) 2018 Juan A. Rubio
This software is part of the Tizonia project <http://tizonia.org>

[Google Play Music] [Connecting] : '*********@gmail.com'.
/usr/local/lib/python2.7/dist-packages/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
[Google Play Music] [Authenticating] : 'with cached auth token'
[Google Play Music] [Retrieving activities] : '*********@gmail.com'. 
[Google Play Music] [Activity search in Google Play Music] : 'working office radio'. 
[Google Play Music] [Activity] 'Deep focus instrumentals : We'll play you music (without lyrics) to help you focus. Just pick a station.'.
[Google Play Music] Playing 'Deep focus instrumentals'.
[Google Play Music] [Track] 'I'm Amazed' by 'My Morning Jacket'.
[Google Play Music] [Track] 'Up Around The Bend' by 'Creedence Clearwater Revival'.
[Google Play Music] [Track] 'Blue' by 'The Jayhawks'.
[Google Play Music] [Track] 'Knoxville Girl' by 'The Outlaws'.
[Google Play Music] [Track] 'Caught Up In You' by '38 Special'.
[Google Play Music] [Track] 'Dreams I'll Never See' by 'Molly Hatchet'.
[Google Play Music] [Track] 'Guitar Town' by 'Steve Earle'.
[Google Play Music] [Track] 'Learn How to Love' by 'Tedeschi Trucks Band'.
[Google Play Music] [Track] 'Excuse Me While I Break My Own Heart Tonight (Strangers Almanac Album Version)' by 'Whiskeytown'.
[Google Play Music] [Track] 'White Trash Millionaire' by 'Black Stone Cherry'.
[Google Play Music] [Track] 'Don't Wanna Fight' by 'Alabama Shakes'.
[Google Play Music] [Track] 'Can't Get High' by 'Widespread Panic'.
[Google Play Music] [Track] 'Homegrown' by 'Zac Brown Band'.
[Google Play Music] [Track] 'Hamburger Midnight' by 'Little Feat'.
[Google Play Music] [Track] 'Already Gone' by 'Eagles'.
[Google Play Music] [Track] 'Toes' by 'Zac Brown Band'.
[Google Play Music] [Track] 'Dixie Rock' by 'Wet Willie'.
[Google Play Music] [Track] 'Fire on the Mountain' by 'The Marshall Tucker Band'.
[Google Play Music] [Track] 'Gimme Three Steps' by 'Lynyrd Skynyrd'.
[Google Play Music] [Track] 'The South's Gonna Do It Again' by 'The Charlie Daniels Band'.
[Google Play Music] [Track] 'Now That Your Dollar Bills Have Sprouted Wings' by 'Jason Isbell'.
[Google Play Music] [Track] 'Black Betty' by 'Ram Jam'.
[Google Play Music] [Track] 'White Lies' by 'Jason & The Scorchers'.
[Google Play Music] [Track] 'Wrap It Up' by 'The Fabulous Thunderbirds'.
[Google Play Music] [Track] 'Heard It On The X (Remastered Version)' by 'ZZ Top'.
[Google Play Music] [Tracks in queue] '25'.
[Google Play Music] [Connected] : '*********@gmail.com'.
[Google Play Music] [Connected] : '*********@gmail.com'.
   My Morning Jacket : I'm Amazed
     Album : Evil Urges
     Year : 2008
     Duration : 4m:33s
     Track # : 4
     2 Ch, 44.1 KHz, 16:s:b 
@tizonia

This comment has been minimized.

Owner

tizonia commented Aug 22, 2018

The results provided with my google account (and from my current location) are different.

One thing you could try and see if it makes a difference is to try and upgrade all the pip dependencies, in case something is not up-to-date.

See https://github.com/tizonia/tizonia-openmax-il#upgrade-debian--ubuntu--raspbian, but essentially you just need to type:

 $ sudo -H pip install --upgrade gmusicapi soundcloud youtube-dl pafy pycountry titlecase pychromecast plexapi fuzzywuzzy eventlet && sudo -H pip install git+https://github.com/plamere/spotipy.git --upgrade
@ionyx0

This comment has been minimized.

ionyx0 commented Aug 22, 2018

Tizonia and all dependencies are updated and I'm getting the same results (as in unexpected tracks).

Is there a flag that will enable some kind of debug to gather more information? Or would I need to build the debug release and run that way?

@tizonia

This comment has been minimized.

Owner

tizonia commented Aug 22, 2018

TIZONIA_GMUSICPROXY_DEBUG=1 will provide information. Just export it on your shell or add it before Tizonia in the same command line.

@tizonia

This comment has been minimized.

Owner

tizonia commented Aug 22, 2018

OK, I think I got what you mean by 'unexpected tracks'. Regardless of whether you get the right 'station' selected, the actual songs in it don't seem to belong to that particular 'activity'.

I think you are actually right in that there is something wrong with those songs. I'll investigate.

@ionyx0

This comment has been minimized.

ionyx0 commented Aug 23, 2018

Thanks for checking it out. If you want, I can send over the debug logs from earlier. I haven't had a chance to go through them to see if anything sticks out.

In addition to the unexpected tracks (which also happens when trying to just play a station, ie --gmusic-unlimited-station 'Trappy Instrumentals'), "Deep focus instrumentals" is the only Activity station I can get to come back from the API when the search term starts with "working". Maybe that's just coincidence, but thought I'd point it out.

@tizonia

This comment has been minimized.

Owner

tizonia commented Aug 23, 2018

Please attach here your logs. It will help me for sure.

@ionyx0

This comment has been minimized.

ionyx0 commented Aug 23, 2018

Here you go. Tried to remove any personal info from the logs. Let me know if you need more.
tizlog.log

@tizonia tizonia added the bug label Aug 28, 2018

@tizonia tizonia added this to the v0.16.0 milestone Aug 28, 2018

juanrubio added a commit that referenced this issue Dec 3, 2018

OMX_TizoniaExt.h: added cAdditionalKeywords field to
OMX_TIZONIA_AUDIO_PARAM_GMUSICPLAYLISTTYPE (part of #507)

juanrubio added a commit that referenced this issue Dec 3, 2018

juanrubio added a commit that referenced this issue Dec 3, 2018

juanrubio added a commit that referenced this issue Dec 3, 2018

juanrubio added a commit that referenced this issue Dec 3, 2018

@juanrubio

This comment has been minimized.

Collaborator

juanrubio commented Dec 3, 2018

This issue is being fixed with the introduction of the optional argument '--gmusic-additional-keywords' in conjunction with the existing '--gmusic-unlimited-activity'.

This will allow Tizonia to filter based on station names, once a list of stations has been retrieved for a specified activity.

$ tizonia --gmusic-unlimited-activity "working" --gmusic-additional-keywords 'working to a beat'
tizonia 0.15.0. Copyright (C) 2018 Juan A. Rubio
This software is part of the Tizonia project <http://tizonia.org>

[Google Play Music] [Connecting] : 'user'.
[Google Play Music] [Authenticating] : 'with cached auth token'
[Google Play Music] [Retrieving activities] : 'user'. 
[Google Play Music] [Activity search in Google Play Music] : 'working'. 
[Google Play Music] [Activity search in Google Play Music] : 'Additional keywords : working to a beat'. 
[Google Play Music] [working - working to a beat] 'Classical for Working : Whether you're studying or filling out expense reports, these classical pieces will help you get the job done. '.
[Google Play Music] [working - working to a beat] 'Jazz for Working : Delve into jazz's classic era, at tempos that won't put you to sleep or get you too wound up to work.'.
[Google Play Music] [working - working to a beat] 'Working to a Beat : House, Prog and Trance for when you need to take care of business.'.
[Google Play Music] [working - working to a beat] 'Piano Sonatas for Working : Stay focused with these piano-driven Classical and Jazz instrumentals, made to delight and inspire.'.
[Google Play Music] [working - working to a beat] 'Working Out Loud : Give that Nordic cross trainer hell with this power playlist of feisty electro-pop.'.
[Google Play Music] [working - working to a beat] 'Progressive Trance for Working : Stimulate your mind with the heady rush of these progressive trance tracks.'.
[Google Play Music] [working - working to a beat] 'Techno for Working Hard : Minimalist German Techno for when 


...


[Google Play Music] Playing 'Working to a Beat'.
[Google Play Music] [Station] : 'Working to a Beat'.
[Google Play Music] [Track] 'Out Of My Head (Original Mix) (feat. Ovasoul7)' by 'Deetron'.
[Google Play Music] [Track] 'House Of Now (Tiesto Edit)' by 'MOTi'.
[Google Play Music] [Track] 'Blind Heart (Didrick Remix)' by 'Cazzette'.
[Google Play Music] [Track] 'Katz' by 'Pote'.
[Google Play Music] [Track] 'Renaissance (Original Mix)' by '2Fake'.
[Google Play Music] [Track] 'FACES' by 'The Blaze'.
...
..

@juanrubio juanrubio closed this in fd96a5a Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment