Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotify: config option to allow/disallow 'explicit' tracks #568

Closed
juanrubio opened this issue Mar 3, 2019 · 7 comments
Closed

Spotify: config option to allow/disallow 'explicit' tracks #568

juanrubio opened this issue Mar 3, 2019 · 7 comments
Assignees
Milestone

Comments

@juanrubio
Copy link
Member

@juanrubio juanrubio commented Mar 3, 2019

The goal is to have a configuration file option and command-line flag to allow-disallow explit songs.

@tizonia
Copy link
Collaborator

@tizonia tizonia commented Mar 13, 2019

Changes are in the develop branch. Will be merged to master soon.

@juanrubio juanrubio closed this in 9d07713 Mar 13, 2019
@WhiskeyTuesday
Copy link

@WhiskeyTuesday WhiskeyTuesday commented Sep 1, 2019

Tizonia 0.18.0 installed via apt on Ubuntu 18.04 has this option in its default config file but changing it to true doesn't seem to actually do anything. calling tizonia --spotify-playlist on a playlist with explicit tracks still gives 'explicit tracks removed'. calling with --spotify-allow-explicit-tracks does work as intended however.

@ROF618
Copy link

@ROF618 ROF618 commented Jan 19, 2020

Having the same problem as @WhiskeyTuesday. I also am running Ubuntu 18.04 lts and my Tizonia is version 0.19.0.

@WhiskeyTuesday
Copy link

@WhiskeyTuesday WhiskeyTuesday commented Jan 19, 2020

@ROF618 spotify.allow_explicit_tracks = true in the config file works on my current install which is 0.18.0 installed with snapd on Pop_OS (Ubuntu) 19.10. I can't remember if it just started working when I switched to the snap installed version, or when I switched to 19.10... or... I vaguely remember the default version of the line in the config file is commented out but doesn't include = true maybe?

I've clearly forgotten everything but hopefully this is helpful in some way.

@tizonia
Copy link
Collaborator

@tizonia tizonia commented Jan 19, 2020

@WhiskeyTuesday , @ROF618

Apologies, this fell through the cracks. Yes, the config option works for me as well.

The config parser is not very good (maybe that's even an overstatement!), so you need to make sure your config lines look clean like this (no comment symbols '#' before or after, etc).

spotify.allow_explicit_tracks = false

@WhiskeyTuesday
Copy link

@WhiskeyTuesday WhiskeyTuesday commented Jan 20, 2020

@tizonia now that you mention it I think that's what fixed it. I think I originally had an inline comment after the option, on the same line.

@tizonia
Copy link
Collaborator

@tizonia tizonia commented Jan 20, 2020

@WhiskeyTuesday

The fix for this particular problem (options ignored if comment at the end of the line) is now available in the 'develop' branch.

See #667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants