Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtizonia: tiz_port_set_portdef_format is overriden in the leaf audio ports. #82

Closed
tizonia opened this issue Jun 9, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@tizonia
Copy link
Owner

commented Jun 9, 2014

There empty implementations of this function in the mp3, pcm, aac, opus, vorbis and flac ports. These overrides hide the implementation in tizaudioport, that is the one that actually does the job.

Remove these unnecessary implementations from the leaf port classes.

static OMX_ERRORTYPE flacport_set_portdef_format
  (void *ap_obj, const OMX_PARAM_PORTDEFINITIONTYPE * ap_pdef)
{
  /* TODO */
  return OMX_ErrorNone;
}

@tizonia tizonia added this to the OpenMAX IL 0.1.0 milestone Jun 9, 2014

@tizonia tizonia added the bug label Jun 9, 2014

@tizonia

This comment has been minimized.

Copy link
Owner Author

commented Jun 9, 2014

Closed in 8033c44

@tizonia tizonia closed this Jun 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.