Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Jun 29, 2017
1 check passed
referenced this pull request
Jun 29, 2017
Thx Juan ! Any idea why the eglimage hook is never called ? (https://github.com/tizonia/tizonia-openmax-il/blob/master/plugins/vp8_decoder/src/vp8d.c#L62)
Hi Julien, I think the hook was being called correctly, it is just that it was returning an OMX_ERRORTYPE value, instead of OMX_BOOL.
I've updated it and added some more diagnostics in tizport.c, to catch this situation easily in the future.
I'm pushing a new Skema test (Vp8DecoderEGLImage.xml) that might be useful to see this in action.
Interesting. I think there may be a problem if a the component role is explicitely reset by the IL client. If this happens (with SetParameter(OMX_IndexParamStandardComponentRole), then the new role objects are instantiated. I.e the processor and port objects are destroyed and a new set is instantiated. And I believe in this case I forgot to re-assign the hooks. So moving the hook registration to the processor constructor actually workarounds this problem :-)
Let me have a look, I think I can provide a fix in tizscheduler.c, to avoid having to move the hook registration call to the processor.