Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #344

Merged
merged 7 commits into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
@CapOM
Copy link

commented Jun 29, 2017

2 minors fixes
1 debatable commit that serves as example,
1 WIP commit that requires feedback because the hook is never called.
Thx!

tizonia and others added some commits Jun 27, 2017

Julien Isorce
tizvideoport: use correct formatting for bitrate and stride
It was %s so it was even crashing sometimes.
Replaced by %d by symmetry with others outputs
despite the type being OMX_U32.

Signed-off-by: Julien Isorce <jisorce@oblong.com>
Julien Isorce
WIP vp8d: register eglimage hook
FIXME: somehow the hook is never called.

The hook returns OMX_ErrorNotImplemented to advretise
clients that they cannot use OMX_UseEGLImage.

Signed-off-by: Julien Isorce <jisorce@oblong.com>
Julien Isorce
vp8dprc: if header->pBuffer is NULL then claim the eglimage handle.
This only serve as reference implementation.

Signed-off-by: Julien Isorce <jisorce@oblong.com>
Julien Isorce
tizonia-dpkg-build: add missing 'done'
Signed-off-by: Julien Isorce <jisorce@oblong.com>
@juanrubio
Copy link
Collaborator

left a comment

Let's move everything into master. I can't find anything wrong right now, so I will polish it from master if needed.

@juanrubio juanrubio merged commit 58e35a7 into tizonia:master Jun 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@CapOM

This comment has been minimized.

Copy link
Author

commented Jun 30, 2017

Thx Juan ! Any idea why the eglimage hook is never called ? (https://github.com/tizonia/tizonia-openmax-il/blob/master/plugins/vp8_decoder/src/vp8d.c#L62)

@juanrubio

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2017

Hi Julien, I think the hook was being called correctly, it is just that it was returning an OMX_ERRORTYPE value, instead of OMX_BOOL.

I've updated it and added some more diagnostics in tizport.c, to catch this situation easily in the future.

I'm pushing a new Skema test (Vp8DecoderEGLImage.xml) that might be useful to see this in action.

@CapOM

This comment has been minimized.

Copy link
Author

commented Jun 30, 2017

Ah ok, I will re-try then maybe I missed something, the other day I added a trace and it did not show up. Thx !

@CapOM

This comment has been minimized.

Copy link
Author

commented Jul 1, 2017

I found the problem and it affects only the output port. The eglimage hook is correctly registered but then it is lost because the output port is re-created or super seeded somehow. Is this normal ? Also see #347

@juanrubio

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2017

Hi Julien,

Interesting. I think there may be a problem if a the component role is explicitely reset by the IL client. If this happens (with SetParameter(OMX_IndexParamStandardComponentRole), then the new role objects are instantiated. I.e the processor and port objects are destroyed and a new set is instantiated. And I believe in this case I forgot to re-assign the hooks. So moving the hook registration to the processor constructor actually workarounds this problem :-)

Let me have a look, I think I can provide a fix in tizscheduler.c, to avoid having to move the hook registration call to the processor.

@CapOM

This comment has been minimized.

Copy link
Author

commented Jul 2, 2017

Make sense, great, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.