Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framerate #359

Merged
merged 2 commits into from Jul 26, 2017

Conversation

Projects
None yet
2 participants
@CapOM
Copy link

commented Jul 26, 2017

xFramerate is currently not handled properly. As per spec it is in Q16 format.

Julien Isorce added some commits Jul 26, 2017

Julien Isorce
Fix xFramerate handling which is in Q16 format
From the spec 1.1.2 and 1.2.0:
"""
xFramerate is the frame rate is in frames per second. This value is represented
in Q16 format. The value 0x0 is used to indicate the frame rate is unknown,
variable, or is not needed.
"""

Signed-off-by: Julien Isorce <jisorce@oblong.com>
Julien Isorce
vp8dprc: update output port params upon stride change but not upon un…
…known framerate

Signed-off-by: Julien Isorce <jisorce@oblong.com>
@juanrubio
Copy link
Collaborator

left a comment

All looks good to me.

@juanrubio
Copy link
Collaborator

left a comment

This also looks correct to me.

@juanrubio juanrubio merged commit fabd6f0 into tizonia:master Jul 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juanrubio

This comment has been minimized.

Copy link
Collaborator

commented Jul 26, 2017

Thanks Julien. I forgot about the framerate being a Q16 number!. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.