Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vp8_decoder: add inport_SetParameter to set nBufferSize #363

Merged
merged 1 commit into from Aug 13, 2017

Conversation

@CapOM
Copy link

@CapOM CapOM commented Aug 12, 2017

This allows the component to decide the nBufferSize
depending on the resolution and framerate and prior
its internal parsing.
Indeed the demuxer will know this information before
the decoder.

This allows the component to decide the nBufferSize
depending on the resolution and framerate and prior
its internal parsing.
Indeed the demuxer will know this information before
the decoder.
@CapOM CapOM force-pushed the CapOM:vp8_decoder_InputPort_SetParameter branch from c2952fb to 4ff185c Aug 13, 2017
@ghost
ghost approved these changes Aug 13, 2017
Copy link
Collaborator

@ghost ghost left a comment

Hi Julien,

Thanks for the patch.

Normally, instead of overriding SetParameter, I would override this other function:

  • tiz_port_set_portdef_format,

Which has an override in tizvideoport:

  • videoport_set_portdef_format

so essentially I would provide my own override of this "set_portdef_format" function in the vp8 decoder in port.

It can be done in SetParameter as you have done, but "set_portdef_format" is a virtual function designed for this type of thing.

I'll pull the patch, and I'll port the code to the other function later.

Thanks again!

@tizonia tizonia merged commit 130825e into tizonia:master Aug 13, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@CapOM
Copy link
Author

@CapOM CapOM commented Aug 14, 2017

Thx!

@CapOM
Copy link
Author

@CapOM CapOM commented Aug 23, 2017

"and I'll port the code to the other function later."
Gentle ping just in case you forgot. Thx in advance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.