Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aac_decoder optional #422

Merged
merged 1 commit into from Dec 20, 2017
Merged

Make aac_decoder optional #422

merged 1 commit into from Dec 20, 2017

Conversation

@lgbaldoni
Copy link
Contributor

@lgbaldoni lgbaldoni commented Dec 20, 2017

aac_decoder relies on libfaad which is legally problematic in some jurisdictions on account of extant patents.

@codecov
Copy link

@codecov codecov bot commented Dec 20, 2017

Codecov Report

Merging #422 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage    47.3%   47.29%   -0.01%     
==========================================
  Files         219      219              
  Lines       38796    38796              
==========================================
- Hits        18351    18349       -2     
- Misses      20445    20447       +2
Impacted Files Coverage Δ
libtizplatform/src/ev/ev.c 26.32% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd0d86...37aae1c. Read the comment docs.

@juanrubio juanrubio merged commit 7e45b4f into tizonia:master Dec 20, 2017
3 of 4 checks passed
3 of 4 checks passed
@codecov
codecov/project 47.29% (-0.01%) compared to 3fd0d86
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
@codecov
codecov/patch Coverage not affected when comparing 3fd0d86...37aae1c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@juanrubio
Copy link
Member

@juanrubio juanrubio commented Dec 20, 2017

This looks good. Thanks!

@lgbaldoni lgbaldoni deleted the lgbaldoni:switches branch Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants