Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not pin requests #6

Open
jone opened this issue May 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@jone
Copy link

commented May 7, 2019

This package has a specific pinning for the exact version of requests==2.18.4 in the install_requires in the setup.py.
Please do not pin an exact version, but use a version constraint (e.g. requests>=2.18.4).
It is a very bad habit to pin exact versions in setup.py because if two packages do that they cannot be installed at the same time.

@tizz98

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Pull requests are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.