Add Twitter's bootstrap toolkit #34

Merged
merged 3 commits into from Aug 30, 2011

Projects

None yet

2 participants

@rricard
rricard commented Aug 30, 2011

I just wanted support for bootstrap in asset.

You can now require bootstrap and bootstrap-less (the less source version) in your project !

@tj tj and 1 other commented on an outdated diff Aug 30, 2011
assets.json
@@ -17,6 +17,29 @@
],
"version": "1.0"
},
+ "bootstrap": {
+ "url": "https://github.com/twitter/bootstrap/raw/master/bootstrap-1.1.1.css",
@tj
tj Aug 30, 2011 owner

not sure if you want to add {version} in there

@tj
tj Aug 30, 2011 owner

but cool :D thanks

@rricard
rricard Aug 30, 2011

I've already tried this in fact :
https://github.com/twitter/bootstrap/raw/v{version}/bootstrap-{version}.css

But it downloads and calls the file bootstrap-{version}.css in my public folder ...

Maybe I can try to modify this behavior. I'll see it later

@tj
tj Aug 30, 2011 owner

ohhhh I probably have a bug doing one replace only, I'll fix that then, thanks!

@rricard
rricard commented Aug 30, 2011

I've fixed the {version} bug. Now, everything seems to be ok !

@tj tj merged commit f82b2c3 into tj:master Aug 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment