Options for engines #7

Closed
szarouski opened this Issue Feb 28, 2014 · 0 comments

Projects

None yet

1 participant

@szarouski

Hello, I ran into situation when ect was throwing an error because it couldn't locate parent template ex:<% extend 'layout.html' %>. I was simply trying to read layout.html an of course failing. That happens because there is no way right now to pass options to engines. So... I found two ways of fixing the issue - 1) fix it on ECT side and check if root path wasn't set figure out prefix path for the first template which was passed into render function, get beginning path and assign it to the root. 2) Add engine settings parameter to render in co-views, co-render engine call and ect within consolidate (with proper fallback for backwards compatibility).
First approach would require less changes, but doesn't fix the root of the issue. Second approach opens possibility to adjust other engines as well.

I already have fixes and can create requests. Please let me know what you think.

I'll also reference that issue at ect repository to see what creator thinks about it.

Thank you

@szarouski szarouski closed this Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment