Support for `--cflags` style option parameters #174

Closed
euforic opened this Issue Sep 30, 2013 · 1 comment

Projects

None yet

2 participants

@euforic
euforic commented Sep 30, 2013

example

$ cliapp build --cflags "-DDEBUG=1" 
@tonylukasavage
Contributor

+1

The issue is here: https://github.com/visionmedia/commander.js/blob/master/index.js#L547

There's a check that makes sure the next thing on the command line after a required option does not start with -. If it's a required option, though, who cares? Any string after the option itself should be a valid value for the option. I get that it's a validation check to try and account for someone missing a value for a required option, but it's at the expense of valid functionality. I would very much prefer this additional validation be removed for the sake of having better functionality.

@tonylukasavage tonylukasavage added a commit to tonylukasavage/commander.js that referenced this issue Oct 23, 2013
@tonylukasavage tonylukasavage improve unit test for #174 edbcdac
@tj tj closed this in a824896 Nov 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment