Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch exec to execFile to simply protect against spaces in path #1390

Merged
merged 1 commit into from Nov 5, 2020

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Nov 3, 2020

Pull Request

Problem

Tests break if path has spaces.

Related issue: #1388

Solution

The problem is in the test code, not in Commander itself.

Switch from exec to execFile so shell not processing arguments.

@shadowspawn shadowspawn changed the base branch from master to develop Nov 3, 2020
abetomo
abetomo approved these changes Nov 3, 2020
Copy link
Collaborator

@abetomo abetomo left a comment

👍

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Nov 5, 2020
@shadowspawn shadowspawn merged commit 6032a97 into tj:develop Nov 5, 2020
9 checks passed
@shadowspawn shadowspawn deleted the feature/space-in-path branch Nov 5, 2020
@shadowspawn shadowspawn mentioned this pull request Dec 12, 2020
@shadowspawn shadowspawn removed the pending release Merged into a branch for a future release, but not released yet label Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants