Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tips about showing help instead of just missing arguments error #1547

Merged
merged 2 commits into from Jun 13, 2021

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Jun 12, 2021

Pull Request

Problem

The behaviour is changing in Commander 8 for very simple programs which previously could decide after parsing what to do (if anything) about missing command-arguments.

Solution

Add a couple of simple approaches to Migration Tips in CHANGELOG.

I am not sure whether this come up much, but I'm thinking of the fairly casual users of Commander.

CHANGELOG.md Outdated
If you have a simple program without an action handler, you will now get an error if
there are missing command-arguments.

```
Copy link
Collaborator

@abetomo abetomo Jun 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an indent width of 2 is better.
Because other code examples are 2.

It would be nice to have a highlight setting as well. ```js

Copy link
Collaborator Author

@shadowspawn shadowspawn Jun 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@abetomo abetomo left a comment

👍

@shadowspawn shadowspawn merged commit cf58455 into tj:release/8.x Jun 13, 2021
12 checks passed
@shadowspawn shadowspawn deleted the feature/migrations-tips-8 branch Jun 13, 2021
@shadowspawn shadowspawn added the pending release label Jun 13, 2021
@shadowspawn shadowspawn added this to the v8.0.0 milestone Jun 13, 2021
@shadowspawn shadowspawn removed the pending release label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants