Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TypeScript declaration for Option.argumentRejected #1599

Merged
merged 1 commit into from Sep 10, 2021

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Sep 9, 2021

Pull Request

Problem

Have left over TypeScript declaration for Option.argumentRejected which never shipped.

Resolves: #1598

See also: #1392

Solution

Delete the declaration!

Normally deleting a method would be a breaking change, but in this case there is no implementation anyway so I think it is ok to ship in a minor version.

ChangeLog

  • remove stale TypeScript declaration of Option.argumentRejected

@shadowspawn shadowspawn changed the title Remove argument rejected Remove TypeScript declaration for Option.argumentRejected Sep 9, 2021
Copy link
Collaborator

@abetomo abetomo left a comment

👍

@shadowspawn shadowspawn merged commit 4a370a4 into tj:develop Sep 10, 2021
12 checks passed
@shadowspawn shadowspawn added the pending release label Sep 10, 2021
@shadowspawn shadowspawn deleted the feature/remove-argumentRejected branch Sep 10, 2021
@shadowspawn shadowspawn removed the pending release label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants