Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make showSuggestionAfterError true by default #1657

Merged
merged 1 commit into from Dec 21, 2021

Conversation

shadowspawn
Copy link
Collaborator

@shadowspawn shadowspawn commented Dec 21, 2021

Pull Request

In #1590 (comment) I said:

Make the suggestions off by default to minimise breakage in Commander 8, and probably switch to on by default in Commander 9.

I am still happy with the suggestions. I think this adds value for most users.

If accepted, this PR turns it on by default.

ChangeLog

  • changed: showSuggestionAfterError is now on by default

Copy link
Collaborator

@abetomo abetomo left a comment

LGTM!

@shadowspawn
Copy link
Collaborator Author

shadowspawn commented Dec 21, 2021

Thanks @abetomo , very quick!

@shadowspawn shadowspawn merged commit 39993f9 into tj:release/9.x Dec 21, 2021
12 checks passed
@shadowspawn shadowspawn deleted the feature/suggest-by-default branch Dec 21, 2021
@shadowspawn shadowspawn added this to the Commander v9.0.0 milestone Dec 21, 2021
@shadowspawn shadowspawn added the pending release label Dec 21, 2021
@shadowspawn shadowspawn removed the pending release label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants