Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainable name setter #605

Merged
merged 2 commits into from Jun 26, 2017

Conversation

CedricReichenbach
Copy link

@CedricReichenbach CedricReichenbach commented Jan 31, 2017

Similar to description, name now acts as getter or setter, depending on whether an argument is passed or not.

As a result, the command name can now be set through builder-like setups:

program
  .version(myVersion)
  .name('mytool foobar')
  .description('This is a test.');

Cedric Reichenbach added 2 commits January 31, 2017 08:21
Similar to #description, #name now behaves like a setter when
given an argument, and like a setter otherwise.
@zhiyelee
Copy link
Collaborator

This looks good to me

@tproenca
Copy link

+1 to merge!

@robertkowalski
Copy link

LGTM too

@roman-vanesyan
Copy link
Collaborator

@zhiyelee can I merge this pull request, seems lgtm

@roman-vanesyan roman-vanesyan merged commit 57bc3ba into tj:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants