Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added a way to set speaking rate in speech method #57

Merged
merged 2 commits into from Jul 20, 2013

Conversation

Projects
None yet
2 participants
Contributor

kethomassen commented Jul 20, 2013

Overview

Adds a way to set the speaking rate (wpm) in the speech method without having to manually use the applescript method

Examples

speak "HELLO!", "Alex", 250 # Says "HELLO!" with voice "Alex" at a speaking rate of 250 wpm
speak "HELLO!" # Says "HELLO!" with voice "Alex" at a default speaking rate of 175 wpm

Changes

  • Added speech rate parameter to method speech
  • Updated documentation to reflect changes
  • Bumped version to 4.1.4 (from 4.1.3)

@ggilder ggilder commented on an outdated diff Jul 20, 2013

README.rdoc
@@ -159,6 +159,7 @@ following methods to simplify common tasks:
speak 'What is your favorite food? '
food = ask 'favorite food?: '
speak "Wow, I like #{food} too. We have so much in common."
+ speak "I like #{food} aswell!", "Victoria", 190
@ggilder

ggilder Jul 20, 2013

Collaborator

typo "aswell" -> "as well"

@ggilder ggilder commented on an outdated diff Jul 20, 2013

lib/commander/user_interaction.rb
#
# === Examples
#
# speak 'What is your favorite food? '
# food = ask 'favorite food?: '
- # speak "wow, I like #{food} too. We have so much alike."
+ # speak "Wow, I like #{food} too. We have so much in common."
+ # speak "I like #{food} aswell!", "Victoria", 190
@ggilder

ggilder Jul 20, 2013

Collaborator

same typo here

@ggilder ggilder commented on an outdated diff Jul 20, 2013

lib/commander/version.rb
@@ -1,3 +1,3 @@
module Commander
- VERSION = '4.1.3'
+ VERSION = '4.1.5'
@ggilder

ggilder Jul 20, 2013

Collaborator

Why skip 4.1.4?

Collaborator

ggilder commented Jul 20, 2013

Left a couple of comments, looks good to me otherwise. If you fix those I will merge and release.

@kethomassen kethomassen Bump version down to '4.1.4'
* Fixes spelling errors ('aswell' -> 'as well')
* Changes version back down to 4.1.4
5182548
Contributor

kethomassen commented Jul 20, 2013

Fixed 👍

@ggilder ggilder added a commit that referenced this pull request Jul 20, 2013

@ggilder ggilder Merge pull request #57 from kethomassen/master
Added a way to set speaking rate in speech method
6f00a84

@ggilder ggilder merged commit 6f00a84 into tj:master Jul 20, 2013

Collaborator

ggilder commented Jul 21, 2013

Just released v4.1.4 with your addition. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment