Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

According to the JSON RPC 2.0 spec, id can be a string or a number. #3

Merged
merged 1 commit into from Jun 29, 2011
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/connect-jsonrpc.js
@@ -1,4 +1,3 @@

/*!
* Ext JS Connect
* Copyright(c) 2010 Sencha Inc.
Expand Down Expand Up @@ -240,6 +239,6 @@ function jsonrpc(services) {

function validRequest(rpc){
return rpc.jsonrpc === VERSION
&& typeof rpc.id === 'number'
&& (typeof rpc.id === 'number' || typeof rpc.id === 'string')
&& typeof rpc.method === 'string';
}