Callbacks should be moved outside of try-blocks #55

plievone opened this Issue Aug 28, 2012 · 2 comments


None yet

2 participants


There are several places where callbacks are called inside try-blocks. This makes errors further in the chain dangerous and difficult to notice, as they will cause the catch block to fire an errback in some spurious moment. There is issue #37, but the fix there is quite noisy and so may have hidden the intention here.

plievone commented Nov 3, 2012

Commit 806b0ef fixed this only for get, the same problem persists for set.

wavded commented Aug 18, 2014

closing this case as older, please reopen if you want to discuss more

@wavded wavded closed this Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment