New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB is not reselected if the redis client disconnects temporarily #28

Merged
merged 1 commit into from Aug 4, 2011

Conversation

Projects
None yet
4 participants
@cwu
Contributor

cwu commented Aug 4, 2011

I have been getting session objects in my db 0 after setting RedisStore with a different db. (and users losing session data that was in my session db).

This occurs if the client being used by RedisStore disconnects and then reconnects again. When its reconnected it doesn't reselect the proper db (by the nature of the node_redis client).

Related to node_redis issue #86.

I've added the work around noted in issue #86 node_redis.

@tj

This comment has been minimized.

Show comment
Hide comment
@tj

tj Aug 4, 2011

Owner

yikes, that's a pretty bad issue

Owner

tj commented Aug 4, 2011

yikes, that's a pretty bad issue

tj added a commit that referenced this pull request Aug 4, 2011

Merge pull request #28 from cwu/master
DB is not reselected if the redis client disconnects temporarily [cwu]

@tj tj merged commit 7a1b0b2 into tj:master Aug 4, 2011

@dshaw

This comment has been minimized.

Show comment
Hide comment
@dshaw

dshaw Aug 12, 2011

Damn that's ugly. Really wish you could just pass db and auth in the constructor and be done with it.

dshaw commented on 5a07777 Aug 12, 2011

Damn that's ugly. Really wish you could just pass db and auth in the constructor and be done with it.

This comment has been minimized.

Show comment
Hide comment
@tj

tj Aug 12, 2011

Owner

haha yeah quite the hack

Owner

tj replied Aug 12, 2011

haha yeah quite the hack

This comment has been minimized.

Show comment
Hide comment
@cwu

cwu Aug 12, 2011

Contributor

yeah =(. too bad node_redis doesn't remember the db and re-select it for you

Contributor

cwu replied Aug 12, 2011

yeah =(. too bad node_redis doesn't remember the db and re-select it for you

This comment has been minimized.

Show comment
Hide comment
@dshaw

dshaw Aug 12, 2011

Wonder if it's worth trying to patch node_redis?

dshaw replied Aug 12, 2011

Wonder if it's worth trying to patch node_redis?

This comment has been minimized.

Show comment
Hide comment
@matthewmueller

matthewmueller Jul 31, 2012

Ran into this problem today, is there any better way to handle this situation yet?

matthewmueller replied Jul 31, 2012

Ran into this problem today, is there any better way to handle this situation yet?

This comment has been minimized.

Show comment
Hide comment
@tj

tj Jul 31, 2012

Owner

@matthewmueller ideally dont use them at all since they're deprecated IIRC, I think antirez wants people to just use more nodes

Owner

tj replied Jul 31, 2012

@matthewmueller ideally dont use them at all since they're deprecated IIRC, I think antirez wants people to just use more nodes

This comment has been minimized.

Show comment
Hide comment
@matthewmueller

matthewmueller Jul 31, 2012

@visionmedia So instead of multiple databases, span across multiple redis instances?

matthewmueller replied Jul 31, 2012

@visionmedia So instead of multiple databases, span across multiple redis instances?

This comment has been minimized.

Show comment
Hide comment
@tj

tj Jul 31, 2012

Owner

yeah. im not sure when or if it will be removed ever but im pretty sure it's deprecated

Owner

tj replied Jul 31, 2012

yeah. im not sure when or if it will be removed ever but im pretty sure it's deprecated

This comment has been minimized.

Show comment
Hide comment
@matthewmueller

matthewmueller Jul 31, 2012

okay cool, thanks man!

matthewmueller replied Jul 31, 2012

okay cool, thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment