try catch error in 'get' #37

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

dead-horse commented Dec 27, 2011

When I use RedisStore.get, if some error throw in the callback and forget to catch it, it will catch by ‘RedisStore.get’ and do callback(err) again!

In the old test.js, when test RedisStore.length, it will throw an error [TypeError: Object # has no method 'length'], but it will catch in RedisStore.get. I think the try catch in function get should only catch JSON.parse error.

Also I update the test.js ,remove test of RedisStore.length and RedisStore.clear.

heyiyu.pt_52624 and others added some commits Dec 27, 2011

Owner

tj commented Aug 28, 2012

yikes yeah this is really noisy, and you don't follow the existing styling at all (return fn&&fn(err); etc) also what is multi_redis?

Contributor

dead-horse commented Sep 16, 2012

Sorry. I used to modified this module to suits my own redis module multi_redis, so It's such a noisy. I merged the newest version and fix the code style.

+1, I'll volunteer to rewrite if the noise is still holding you back from merging

fengmk2 commented Oct 14, 2012

+1

Owner

tj commented Oct 17, 2012

yeah ideally we squash so there's not 6 commits

Contributor

dead-horse commented Oct 17, 2012

move this to #65

dead-horse closed this Oct 17, 2012

davisford referenced this pull request in socketstream/socketstream Jan 2, 2013

Closed

RedisStore issues #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment