Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix for tab-indented comments #35

Closed
wants to merge 1 commit into from

6 participants

@spmason

I noticed that this wasn't working, so amended the regex slightly to fix it.

I also noticed that part is var'd twice in the same function, so removed the second instance.

Cheers,
Steve

@spmason

Looks like this is a duplicate of #34, though that might be against an earlier version of the code, and mine looks simpler (not sure if that's a good or bad thing?)

@webspinner

I like this fix better than the one I committed, in fact after reading mine again I think I must have been on cough medacine when I wrote it. I want to write some test cases for this event and get back to this cus I think your fix is the right one.

@tj
Owner
tj commented

ewww tabs haha, needs a rebase

@Wolfy87

It would be nice to have this merged in. I'm having to swap all indentation to run my documentation script at the moment.

@evindor
Collaborator

Outdated.

@evindor evindor closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 8, 2011
  1. @spmason
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/dox/index.js
View
2  lib/dox/index.js
@@ -259,7 +259,7 @@ var render = exports.render = function(str, file){
// Support @ignore and --private
if (utils.ignore(part) || (utils.isPrivate(part) && !showPrivate)) continue;
- var part = part.replace(/^ *\* ?/gm, '');
+ part = part.replace(/^[ \t]*\* ?/gm, '');
blocks.push({
comment: markdown.toHTML(utils.toMarkdown(part)),
code: koala.render(".js", utils.escape(next))
Something went wrong with that request. Please try again.