Normalize line endings to work better on windows #54

merged 2 commits into from May 18, 2012


None yet
2 participants

ForbesLindesay commented May 16, 2012

When run on windows with files which had line endings of '\r\n' (which is the default for anything pulled from git) it produced \r on the end of each tag, which was leading to double line breaks for all my tags when rendered in my template. This isn't too important for html, but really messes up markdown outputs.

@tj tj and 1 other commented on an outdated diff May 16, 2012

@@ -24,6 +23,8 @@ exports.version = '0.3.1';
exports.parseComments = function(js, options){
options = options || {};
+ //normalize line endings

tj May 16, 2012


LGTM, we can ditch the comment though I think it's pretty obvious


ForbesLindesay May 18, 2012


Fair enough

@tj tj added a commit that referenced this pull request May 18, 2012

@tj tj Merge pull request #54 from Tuskan360/patch-1
Normalize line endings to work better on windows

@tj tj merged commit 5a031ec into tj:master May 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment