Uninstall bash completion from correct directory #103

Merged
merged 1 commit into from May 15, 2012

Conversation

Projects
None yet
2 participants
@programble
Contributor

programble commented May 15, 2012

Target $(DESTDIR)/etc instead of $(DESTDIR)$(PREFIX)/etc to match install.

Thanks to @geoffgarside for pointing this out.

Uninstall bash completion from correct directory
Target $(DESTDIR)/etc instead of $(DESTDIR)$(PREFIX)/etc to match install.
@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 15, 2012

Owner

I dont remember why we have a DESTDIR instead of a PREFIX

Owner

tj commented May 15, 2012

I dont remember why we have a DESTDIR instead of a PREFIX

tj added a commit that referenced this pull request May 15, 2012

Merge pull request #103 from programble/patch-2
Uninstall bash completion from correct directory

@tj tj merged commit e75980a into tj:master May 15, 2012

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 15, 2012

Owner

hmm I guess DESTDIR is what I always viewed as PREFIX, we definitely shouldn't use both that seems stupid

Owner

tj commented May 15, 2012

hmm I guess DESTDIR is what I always viewed as PREFIX, we definitely shouldn't use both that seems stupid

@programble

This comment has been minimized.

Show comment Hide comment
@programble

programble May 15, 2012

Contributor

It is for packaging purposes. PREFIX is where the files end up on the target box, DESTDIR is where the files are put for the package.

Contributor

programble commented May 15, 2012

It is for packaging purposes. PREFIX is where the files end up on the target box, DESTDIR is where the files are put for the package.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 15, 2012

Owner

yeah I read about it here http://www.gnu.org/software/make/manual/make.html#DESTDIR
maybe it's just me but it seems kinda pointless, at least for git-extras

Owner

tj commented May 15, 2012

yeah I read about it here http://www.gnu.org/software/make/manual/make.html#DESTDIR
maybe it's just me but it seems kinda pointless, at least for git-extras

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 15, 2012

Owner

I've never used nor would I want to, I would just PREFIX in the same way really, but not both

Owner

tj commented May 15, 2012

I've never used nor would I want to, I would just PREFIX in the same way really, but not both

@programble

This comment has been minimized.

Show comment Hide comment
@programble

programble May 16, 2012

Contributor

With only one, you lose the ability to install the files to /usr/local or /usr or anywhere else. It would have to always be /usr I think. The only real problem is that it now also installs things to /etc, which is what requires the separation of the /usr part of the path. Whatever you decide to do, I just hope that it remains easy to package.

Contributor

programble commented May 16, 2012

With only one, you lose the ability to install the files to /usr/local or /usr or anywhere else. It would have to always be /usr I think. The only real problem is that it now also installs things to /etc, which is what requires the separation of the /usr part of the path. Whatever you decide to do, I just hope that it remains easy to package.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 18, 2012

Owner

why is that? previously you could just do make install PREFIX=/usr etc

Owner

tj commented May 18, 2012

why is that? previously you could just do make install PREFIX=/usr etc

@programble

This comment has been minimized.

Show comment Hide comment
@programble

programble May 18, 2012

Contributor

But then the bash completion stuff will still get installed to /etc

Contributor

programble commented May 18, 2012

But then the bash completion stuff will still get installed to /etc

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 18, 2012

Owner

maybe I dont really get why you would want to alter for documents and have a different path for the executables

Owner

tj commented May 18, 2012

maybe I dont really get why you would want to alter for documents and have a different path for the executables

@programble

This comment has been minimized.

Show comment Hide comment
@programble

programble May 18, 2012

Contributor

For a packager, you'd want to be able to put all the files under a certain path, while still preserving the /etc and /usr hierarchy.

Contributor

programble commented May 18, 2012

For a packager, you'd want to be able to put all the files under a certain path, while still preserving the /etc and /usr hierarchy.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 18, 2012

Owner

what's wrong with installing to $(PREFIX)/share/man/man1/mybin.1, $(PREFIX)/bin/mybin etc?

Owner

tj commented May 18, 2012

what's wrong with installing to $(PREFIX)/share/man/man1/mybin.1, $(PREFIX)/bin/mybin etc?

@programble

This comment has been minimized.

Show comment Hide comment
@programble

programble May 18, 2012

Contributor

How do you get the bash completion to go in /etc using $(PREFIX)?

Contributor

programble commented May 18, 2012

How do you get the bash completion to go in /etc using $(PREFIX)?

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 18, 2012

Owner

why does it have to be in /etc? I'd prefer if it wasn't personally, less sudo if you don't own it

Owner

tj commented May 18, 2012

why does it have to be in /etc? I'd prefer if it wasn't personally, less sudo if you don't own it

@programble

This comment has been minimized.

Show comment Hide comment
@programble

programble May 18, 2012

Contributor

Well because that's where bash completion files have to go, unfortunately.

Contributor

programble commented May 18, 2012

Well because that's where bash completion files have to go, unfortunately.

@tj

This comment has been minimized.

Show comment Hide comment
@tj

tj May 18, 2012

Owner

that is unfortunate, I guess that doesn't explain why we're using cp -f $(BIN) $(DESTDIR)$(PREFIX)/$(BIN); though, other than just for the autocompletion stuff

Owner

tj commented May 18, 2012

that is unfortunate, I guess that doesn't explain why we're using cp -f $(BIN) $(DESTDIR)$(PREFIX)/$(BIN); though, other than just for the autocompletion stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment